Skip to content

feat: dissemble→disassemble - #3923

Open
hippietrail wants to merge 2 commits into
Automattic:masterfrom
hippietrail:dissemble-disassemble
Open

feat: dissemble→disassemble#3923
hippietrail wants to merge 2 commits into
Automattic:masterfrom
hippietrail:dissemble-disassemble

Conversation

@hippietrail

Copy link
Copy Markdown
Collaborator

Issues

N/A

Description

Something I was reading, perhaps on Hacker News, used "dissemble" instead of "disassemble", which the context suggested was intended.

I couldn't find any real pattern of POS or context/trigger words that suggest "dissemble" is correct, so there's a chunky list of it looks for in the sentence that will suggest "disassemble" was intended.

This list only comes into play at all when a form of "dissemble" is found, and it's not all that common.

All derivative terms and their inflections are handled.

How Has This Been Tested?

cargo test

AI Disclosure

  • I am a human and didn't use any AI.
  • I used LLM features of my editor, but not an agent.
  • I used an AI agent interactively.
  • I am an agent or I got an agent to do the work autonomously.

I wrote the code but I asked an AI for a tip here and there to find hiccups and ensure it was nice and Rusty.

If Your PR Implements or Enhances a Linter

  • I made up the sentences in the unit tests.
  • The sentences in the unit tests were generated by an AI.
  • I'm using examples from the bug report / feature request.
  • I collected real-world sentences for the unit tests.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have considered splitting this into smaller pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant