feat: for same reason→for the same reason - #3941
Open
hippietrail wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
N/A
Description
This one's been in my inbox for a while. People use "for x reason" instead of "for the x reason" or "for reasons".
This linter fixes all the common ones I could find.
I also converted
WordSetinto a real Rust collection that works with.collect()by implementingFromIteratorthanks to Google Search's AI giving me really good tips on how to best useWordSetwith a transformed collection rather than its usual static array of static&str.This linter does not convert existing callsites of
WordSet.How Has This Been Tested?
cargo testAI Disclosure
I also used Google Search's AI.
If Your PR Implements or Enhances a Linter
Checklist