Fix Build PHP CLI Binaries GitHub Actions workflow - #4419
Merged
Conversation
To fix the issue where Node could not find the yargs module: - Setup the correct Node version - Run `npm ci`
bcotrim
approved these changes
Aug 3, 2026
bcotrim
left a comment
bcotrim
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍
Note: I haven't confirmed the fix, but the code and fix makes sense
Contributor
Author
|
I've triggered a proper PHP 8.4.24 build from this branch to verify that it works as expected. Will land this PR when that finishes successfully |
Contributor
Author
|
This run succeeded, so I'm merging this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude was used to investigate and implement the solution, which iterative directions from me on the desired end state.
Proposed Changes
#4021 introduced a regression where the
Build PHP CLI BinariesGitHub Actions workflow started failing because there are nonode_modulesavailable in the CI runner context. This PR fixes the problem by:npm ciTesting Instructions
Code review is sufficient
Pre-merge Checklist