Skip to content

Code-base debt erasure: Draft#224

Open
kjohn-msft wants to merge 3 commits into
masterfrom
kjohn-frozen
Open

Code-base debt erasure: Draft#224
kjohn-msft wants to merge 3 commits into
masterfrom
kjohn-frozen

Conversation

@kjohn-msft

Copy link
Copy Markdown
Collaborator

This is a draft PR covering more than 30 issues/bugs that have existed as debt in the code-base (some for years).

The code has also been reorganized for consistent coding practices, higher reliability in execution, easier maintainability and faster troubleshooting.

This description will be enhanced when the code is ready for review. Portions of this may go in as separate reviews.

@codecov

codecov Bot commented Oct 31, 2023

Copy link
Copy Markdown

Codecov Report

Merging #224 (173c522) into master (b50ef62) will decrease coverage by 53.11%.
The diff coverage is 22.78%.

@@             Coverage Diff             @@
##           master     #224       +/-   ##
===========================================
- Coverage   90.39%   37.28%   -53.11%     
===========================================
  Files          90       70       -20     
  Lines       14810    11304     -3506     
===========================================
- Hits        13387     4215     -9172     
- Misses       1423     7089     +5666     
Flag Coverage Δ
python27 37.28% <22.78%> (-53.11%) ⬇️
python39 37.28% <22.78%> (-53.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/core/src/bootstrap/Constants.py 98.77% <100.00%> (+0.11%) ⬆️
src/core/src/external_dependencies/distro.py 29.08% <ø> (-24.84%) ⬇️
src/core/tests/Test_Container.py 23.52% <ø> (-70.59%) ⬇️
src/core/tests/Test_LifecycleManagerAzure.py 4.16% <ø> (-90.63%) ⬇️
src/core/tests/Test_PackageFilter.py 3.70% <ø> (-95.38%) ⬇️
src/core/tests/Test_Stopwatch.py 2.70% <ø> (-96.42%) ⬇️
src/core/tests/Test_UbuntuProClient.py 2.56% <ø> (-90.85%) ⬇️
src/extension/src/Constants.py 98.07% <100.00%> (+0.01%) ⬆️
src/extension/src/ProcessHandler.py 83.84% <100.00%> (ø)
src/extension/src/RuntimeContextHandler.py 72.00% <ø> (ø)
... and 59 more

... and 18 files with indirect coverage changes

@kjohn-msft kjohn-msft added feature New feature or request draft Work in progress or planned for later labels Mar 14, 2025
@kjohn-msft kjohn-msft self-assigned this Mar 14, 2025
kjohn-msft added a commit that referenced this pull request Jun 29, 2026
…t + misc. improvements (#313)

Packager updates pulled out to code base debt erasure (and revised a
little further):
#224

**Changes in this PR:**
1. Addition of **build.bat / .sh** in the src folder to package all
components. [Builds **without** version change]
2. Addition of **publish.bat / .sh** in the src folder to increment the
manifest version and package all components. (reduces friction in PR for
publish, i.e. new branch -> publish (at prompt) -> push branch -> PR)
[Builds **with** automatic version increase]
3. Removal of version information from multiple places and centralizing
to the manifest source of truth that gets used in packaging.
4. Moved packager scripts to a packager sub-folder. Updated references.
_This will be reflected in the internal make file._
5. Updated component naming to reduce confusion in multi-extension
support scenarios.
6. Cleanup output and removed misc. debt.

Example of Publish output now (a super-set of build / package) --

![image](https://github.com/user-attachments/assets/f7f1d09b-ebc3-469a-b43e-405c7f4008b1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

draft Work in progress or planned for later feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant