Skip to content

AMA: enable libcurl ODS upload (ENABLE_CURL_UPLOAD) in eastus2euap and centraluseuap#2190

Merged
simathih merged 3 commits into
masterfrom
siddhartha/enable-curl-upload-eastus2euap
Jun 30, 2026
Merged

AMA: enable libcurl ODS upload (ENABLE_CURL_UPLOAD) in eastus2euap and centraluseuap#2190
simathih merged 3 commits into
masterfrom
siddhartha/enable-curl-upload-eastus2euap

Conversation

@simathih

Copy link
Copy Markdown
Collaborator

Summary

Gate the libcurl-based ODS upload path (ENABLE_CURL_UPLOAD) behind region detection so it is enabled only in eastus2euap for canary rollout.

Changes

  • Added enableCurlUpload to feature_support_matrix in is_feature_enabled(), scoped to ['eastus2euap'].
  • In enable(), when the feature is enabled for the region, write export ENABLE_CURL_UPLOAD=true into /etc/default/azuremonitoragent via default_configs.

Why this approach

  • Reuses the existing region-gating mechanism used by useDynamicSSL / enableAzureOTelCollector (region from IMDS via get_azure_environment_and_region()).
  • Respects per-VM previewFeatures override flag files: enableCurlUpload force-enables and enableCurlUploadDisabled force-disables, useful for targeted testing or emergency opt-out.
  • Only sets the variable when enabled; all other regions keep the default opt-in (off) behavior of the agent's ENABLE_CURL_UPLOAD env var.

Gate the libcurl-based ODS upload path behind region detection using the existing is_feature_enabled/feature_support_matrix mechanism. enableCurlUpload is scoped to eastus2euap for canary rollout; when enabled, the extension writes export ENABLE_CURL_UPLOAD=true to /etc/default/azuremonitoragent. Per-VM previewFeatures override flag files continue to force enable/disable.
@simathih simathih requested a review from a team as a code owner June 27, 2026 20:00
Comment thread AzureMonitorAgent/agent.py Outdated
Addresses PR review comment to add centraluseuap to the canary region gate for enableCurlUpload, alongside eastus2euap. Updates comment and UTs (adds centraluseuap-enabled test, removes it from the disabled-region list).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@simathih simathih changed the title AMA: enable libcurl ODS upload (ENABLE_CURL_UPLOAD) only in eastus2euap AMA: enable libcurl ODS upload (ENABLE_CURL_UPLOAD) in eastus2euap and centraluseuap Jun 30, 2026
@simathih simathih merged commit ba1f933 into master Jun 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants