[tests/acl]: Check ACL rule active status in acl_rule_loaded - #1375
Open
Aakash Tiwari (aakashtiwari2630-max) wants to merge 1 commit into
Open
[tests/acl]: Check ACL rule active status in acl_rule_loaded#1375Aakash Tiwari (aakashtiwari2630-max) wants to merge 1 commit into
Aakash Tiwari (aakashtiwari2630-max) wants to merge 1 commit into
Conversation
Signed-off-by: Aakash Tiwari <aaktiwar@cisco.com>
Aakash Tiwari (aakashtiwari2630-max)
requested a review
from xwjiang-ms
as a code owner
August 27, 2026 00:10
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Porting master PR: sonic-net/sonic-mgmt#22782
Summary of fix:
Currently the logic in acl_rule_loaded(), checks for the presence of ACL rule and gives a false positive and returns True even if the rule is not active. Due to this the wait_until() function which has a wait timeout of 15s, returns immediately and the tests proceeds even though the rule is not active and the test fails in traffic validation.
Enhanced acl_rule_loaded() to verify that all expected ACL rules are not only present but also in 'Active' state before returning True. This will make sure that the test waits until the timeout if rule is not installed before traffic validation.
Also added a helper function to check if ACL table is created and active before verifying traffic.