Bump JsRuntimeHost to fix WorkQueue destructor deadlock - #1654
Merged
Conversation
Updates JsRuntimeHost to include the fix for a race condition in WorkQueue::~WorkQueue() where cancel() + notify_all() could miss condition_variable::wait(), causing a deadlock on thread join. See BabylonJS/JsRuntimeHost#147 for details. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Babylon Native dependency pin for JsRuntimeHost to pull in an upstream fix for a shutdown deadlock in WorkQueue::~WorkQueue() (race between cancel() / notify_all() and condition_variable::wait()), aligning this repo with BabylonJS/JsRuntimeHost#147.
Changes:
- Bump
JsRuntimeHostFetchContent_DeclareGIT_TAGto a newer commit that includes the WorkQueue destructor deadlock fix.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ryantrem
approved these changes
Apr 8, 2026
bkaradzic-microsoft
pushed a commit
to bkaradzic-microsoft/BabylonNative
that referenced
this pull request
Jul 16, 2026
…(idx 124/125/287/299) The SPIRV-Cross HLSL transpile assert cluster (TPC issues BabylonJS#1601/BabylonJS#1602/BabylonJS#1603/ BabylonJS#1604/BabylonJS#1654, all now CLOSED+Done) was resolved by disabling WebMin (BABYLON_NATIVE_DISABLE_WEBMIN=ON undefines SPIRV_CROSS_WEBMIN, so OpFMod and the other trimmed HLSL ops no longer compile to SPIRV_CROSS_INVALID_CALL asserts). Empirically re-tested all affected indices plus every still-excluded test with a crash/assert/compile reason: zero crashes remain. Swept the 4 tests still carrying stale crash exclusion reasons that now pass on Win32/D3D11: - 124/125 IES Profile (were 'crashes or hangs') - 287 Prepass SSAO + particles (was 'SSAO2 blur fails to compile') - 299 Prepass SSAO + GUI (was 'order-dependent state leak') Full regression: 424/424 enabled tests pass, zero regressions; 299's documented order-dependent leak did not reproduce in the full single-process sweep. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 60c2ec68-6de1-445d-9fc9-b699db737eae
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump JsRuntimeHost to include the fix for a race condition in WorkQueue::~WorkQueue() where cancel() + notify_all() could miss condition_variable::wait(), causing a deadlock on thread join during shutdown.
See BabylonJS/JsRuntimeHost#147 for full details and threading diagrams.