Build guarded PhoenixCore Mobile APK - #146
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 599b6b2d4e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Prepare guarded Android coordinator shell | ||
| run: | | ||
| npm install --no-save @capacitor/core@7 @capacitor/cli@7 @capacitor/android@7 | ||
| printf '%s\n' '{ "appId": "com.bobbysworkshop.phoenixcore", "appName": "PhoenixCore Mobile", "webDir": "dist" }' > capacitor.config.json |
There was a problem hiding this comment.
Add runtime handlers for the packaged dashboard APIs
When this APK is installed, it contains only dashboard/dist, but every diagnostic and planning action in dashboard/src/App.jsx calls relative /api/... endpoints. Repository-wide inspection shows those handlers exist only in the Vite configureServer development middleware in dashboard/vite.config.js, which is not included in the production bundle, and this workflow adds no native or remote replacement. Consequently, USB scanning, image inspection, planning, audits, and simulations all fail in the packaged app, leaving only the static UI; add an Android-capable bridge/backend or a mobile-specific client before publishing the artifact.
Useful? React with 👍 / 👎.
Builds the PhoenixCore diagnostics/planning dashboard for Android. Physical USB imaging remains disabled because Android requires a separately validated USB Host/SAF implementation.