Skip to content

Do not inherit the height of the roof - #155

Open
deevroman wants to merge 1 commit into
Beakerboy:mainfrom
deevroman:not-inherit-roof-height
Open

Do not inherit the height of the roof#155
deevroman wants to merge 1 commit into
Beakerboy:mainfrom
deevroman:not-inherit-roof-height

Conversation

@deevroman

@deevroman deevroman commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

And again, the Eiffel Tower. The roof:height=330 and height=330 tags have been added to the outline.

Only height=4 is set on building:part. Now let's look at how the roofs are rendered:

roof.position.set(0, this.options.building.height - this.options.roof.height, 0);

Due to inheritance for building:part we get the height 4 - 330 = -326:

After fix:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant