Configure Express trust proxy for Cloud Run / reverse proxy deployments - #2
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix code as per review comment 3447081477
Configure Express trust proxy for Cloud Run / reverse proxy deployments
Jun 21, 2026
fsu9913-gif
approved these changes
Jun 21, 2026
There was a problem hiding this comment.
Pull request overview
This PR configures the Express server to correctly resolve client IP addresses (via req.ip) when deployed behind Cloud Run or another reverse proxy, so IP-based logging/rate-limiting logic works as intended.
Changes:
- Set Express
trust proxyto1immediately after app creation to honor forwarded IP headers behind a single proxy hop.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const app = express(); | ||
| const PORT = Number(process.env.PORT) || 3000; | ||
|
|
||
| app.set("trust proxy", 1); |
fsu9913-gif
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without
trust proxyset, Express ignoresX-Forwarded-Forand resolvesreq.ipto the proxy's address—breaking IP-based rate limiting and audit logging when running behind Cloud Run or any reverse proxy.Change
server.ts: Addapp.set("trust proxy", 1)immediately after app instantiation so Express correctly derives client IPs from the forwarded header chain.