Skip to content

pkg-config warning fixes#4

Merged
bonachea merged 2 commits into
BerkeleyLab:developfrom
bonachea:warning-fixes
May 12, 2026
Merged

pkg-config warning fixes#4
bonachea merged 2 commits into
BerkeleyLab:developfrom
bonachea:warning-fixes

Conversation

@bonachea
Copy link
Copy Markdown
Member

Fix harmless warnings from pkg-config --validate that arise during make check.

Example warnings:

gasnet-smp-seq.pc:24: warning: whitespace encountered while parsing key section
gasnet-smp-seq.pc:25: warning: whitespace encountered while parsing key section
gasnet-smp-seq.pc:26: warning: whitespace encountered while parsing key section
gasnet-smp-seq.pc:27: warning: whitespace encountered while parsing key section
gasnet-smp-seq.pc:31: warning: malformed version field with whitespace, trimming to [2025.8.1]

@bonachea bonachea requested a review from PHHargrove May 12, 2026 02:26
Copy link
Copy Markdown
Collaborator

@PHHargrove PHHargrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bonachea added 2 commits May 11, 2026 23:17
The format does not allow whitespace between the keyname and the =

Example warnings:
```
gasnet-smp-seq.pc:24: warning: whitespace encountered while parsing key section
gasnet-smp-seq.pc:25: warning: whitespace encountered while parsing key section
gasnet-smp-seq.pc:26: warning: whitespace encountered while parsing key section
gasnet-smp-seq.pc:27: warning: whitespace encountered while parsing key section
```
The Version field doesn't allow whitespace, so `pkg-config --validate` was generating
warnings of the form: (pkg-config 1.8.1)
```
./gasnet-smp-seq.pc:32: warning: malformed version field with whitespace, trimming to [2025.8.1]
```
and `pkg-config --modversion` also omits the trailing information.

Even if this was supported, the raw git describe output is not something that should
be used in automated version comparisons, so convert it into a comment.
@bonachea bonachea merged commit 1156cb6 into BerkeleyLab:develop May 12, 2026
0 of 38 checks passed
@bonachea bonachea deleted the warning-fixes branch May 12, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants