Skip to content

Ap 634 alma jwt #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davezuckerman merged 1 commit into from
Apr 21, 2026
+10 −10
Merged

Ap 634 alma jwt #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/concerns/alma_jwt_validator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def jwk_set

def decode_and_verify_jwt(token)
options = {
algorithm: 'RS256',
algorithm: 'ES256',
verify_expiration: true,
verify_aud: false,
verify_iss: true,
Expand Down
18 changes: 9 additions & 9 deletions spec/controllers/concerns/alma_jwt_validator_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,25 +8,25 @@
let(:jwks_url) { "https://api-na.hosted.exlibrisgroup.com/auth/#{alma_institution_code}/jwks.json" }
let(:expected_iss) { 'Prima' }

# Generate an RSA key pair for testing
let(:rsa_key) { OpenSSL::PKey::RSA.new(2048) }
# Generate an EC key pair for testing
let(:ec_key) { OpenSSL::PKey::EC.generate('prime256v1') }
let(:kid) { 'test-key-id' }
let(:test_payload) { { 'userName' => '10335026', 'iss' => expected_iss } }

# Helper to create JWK hash from RSA key using JWT::JWK
# Helper to create JWK hash from EC key using JWT::JWK
def create_jwk_hash(key, kid)
jwk = JWT::JWK.new(key, kid: kid)
jwk.export
end

# Helper to generate a valid JWT
def generate_jwt(payload, key, kid, algorithm = 'RS256')
def generate_jwt(payload, key, kid, algorithm = 'ES256')
header = { 'kid' => kid, 'alg' => algorithm }
JWT.encode(payload, key, algorithm, header)
end

before do
jwk = create_jwk_hash(rsa_key, kid)
jwk = create_jwk_hash(ec_key, kid)

stub_request(:get, jwks_url)
.to_return(
Expand All @@ -39,7 +39,7 @@ def generate_jwt(payload, key, kid, algorithm = 'RS256')
describe '.decode_and_verify_jwt' do
context 'with a valid JWT' do
it 'returns the decoded payload' do
token = generate_jwt(test_payload, rsa_key, kid)
token = generate_jwt(test_payload, ec_key, kid)
result = AlmaJwtValidator.decode_and_verify_jwt(token)

expect(result).to be_an(Array)
Expand All @@ -51,7 +51,7 @@ def generate_jwt(payload, key, kid, algorithm = 'RS256')
context 'with an invalid signature' do
it 'raises JWT::DecodeError' do
# Generate a token with a different key
different_key = OpenSSL::PKey::RSA.new(2048)
different_key = OpenSSL::PKey::EC.generate('prime256v1')
token = generate_jwt(test_payload, different_key, kid)

expect do
Expand All @@ -62,7 +62,7 @@ def generate_jwt(payload, key, kid, algorithm = 'RS256')

context 'with an unknown key id' do
it 'raises JWT::DecodeError' do
token = generate_jwt(test_payload, rsa_key, 'unknown-kid')
token = generate_jwt(test_payload, ec_key, 'unknown-kid')

expect do
AlmaJwtValidator.decode_and_verify_jwt(token)
Expand All @@ -81,7 +81,7 @@ def generate_jwt(payload, key, kid, algorithm = 'RS256')
context 'when JWKS endpoint is unreachable' do
it 'raises an error' do
stub_request(:get, jwks_url).to_return(status: 500)
token = generate_jwt(test_payload, rsa_key, kid)
token = generate_jwt(test_payload, ec_key, kid)

expect do
AlmaJwtValidator.decode_and_verify_jwt(token)
Expand Down
Loading