Bugfix/5.0.3 - #69
Merged
Merged
Conversation
…so that invalid JSON Schema messages can be sent
…y that contains all of the overrides that have been passed. If more than one match, a random choice will be made, if no factories match, a NoSuchFactoryError will be raised. If there are no overridess then behaviour will continue as before and a random factory will be chosen. This does not walk the embedding tree!! Only the top level embedding will be considered for matching
Cover the override-based factory selection logic (select_embedded_factory_or_sample) and the empty hash bypass behaviour. Remove the redundant attribute-filtering pipeline in manufacture_from_embedded_factory that was stripping valid overrides. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: setting an empty hash as an override forces an empty hash. Faker Maker now examines override parameters when there are multiple embedded factories and selects the most appropriate