Skip to content

feat(sdk-coin-canton): added allocation request builder#8822

Merged
ravibitgo merged 1 commit into
masterfrom
CHALO-479
May 21, 2026
Merged

feat(sdk-coin-canton): added allocation request builder#8822
ravibitgo merged 1 commit into
masterfrom
CHALO-479

Conversation

@ravibitgo
Copy link
Copy Markdown
Contributor

Ticket: CHALO-479

@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 21, 2026

CHALO-479

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support in the Canton SDK for an “AllocationRequest” txRequest (an internal/dummy transaction type) to surface DvP trade/leg details to an allocating party, including a new builder and transaction serialization support.

Changes:

  • Adds TransactionType.AllocationRequest to sdk-core and wires it into Canton’s TransactionBuilderFactory.
  • Introduces AllocationRequestBuilder plus a new AllocationRequest interface for representing the surfaced trade leg details.
  • Extends Canton Transaction encode/decode/broadcast-json handling to support allocationRequestData payloads, and adds unit tests for the new builder.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
modules/sdk-core/src/account-lib/baseCoin/enum.ts Adds new TransactionType.AllocationRequest.
modules/sdk-coin-canton/src/lib/allocationRequestBuilder.ts New builder to construct/validate AllocationRequest objects.
modules/sdk-coin-canton/src/lib/iface.ts Adds AllocationRequest interface and threads it through broadcast/json shapes.
modules/sdk-coin-canton/src/lib/index.ts Exports AllocationRequestBuilder.
modules/sdk-coin-canton/src/lib/transactionBuilderFactory.ts Adds factory routing for TransactionType.AllocationRequest.
modules/sdk-coin-canton/src/lib/transaction/transaction.ts Adds storage + (de)serialization logic for allocationRequestData; treats it as dummy-signable payload.
modules/sdk-coin-canton/test/unit/builder/allocationRequest/allocationRequestBuilder.ts New unit tests for the builder.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread modules/sdk-coin-canton/src/lib/allocationRequestBuilder.ts
@ravibitgo ravibitgo marked this pull request as ready for review May 21, 2026 07:55
@ravibitgo ravibitgo requested review from a team as code owners May 21, 2026 07:55
@ravibitgo ravibitgo merged commit 7f0b0c3 into master May 21, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants