feat(glaziery): ancient runic glass stained chancel window, lead came assembly, and holy light engine - #280
Open
angelTomo9 wants to merge 1 commit into
Conversation
…came assembly, and holy light engine
Code Review ✅ ApprovedImplements ancient runic glass stained chancel windows with lead came assembly and holy light refraction for the OpenAO MMORPG, including window assembly benches, stained glass rondels, chancel window recipes with sanctity scaling, and upfront material deduction to prevent zero-cost retries. Full unit test coverage included. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 1 day — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements an ancient runic glass stained chancel window, lead came assembly, and cathedral holy light refraction system, window assembly benches and easels (Cedar Window Assembly Bench, Runic Lead Came Easel, Celestial Void Chancel Sanctum), stained glass rondels (Cathedral Blue Rondel, Ruby Red Flashed Glass Pane, Celestial Void Holy Light Plate), chancel window recipes (Saint Benedict Protective Window, Sunburst Holy Blessing Chancel, Celestial Void Seraphic Rose Window), sanctuary sanctity ratings (0% to 100%), holy warding and health regen aura scaling, upfront material deduction on all attempts, consistent remainingProvidedGlass shapes across all branches, and assembly easel maintenance for OpenAO MMORPG.
Features