feat(glaziery): ancient runic glass engraving lathe, copper wheel intaglio, and arcane sigil engine

[angelTomo9]

Summary

Implements an ancient runic glass engraving lathe, copper wheel intaglio, and arcane sigil crafting system, glass engraving lathes and intaglio benches (Cedar Glass Engraving Lathe, Runic Copper Wheel Intaglio Bench, Celestial Void Sigil Sanctum), raw quartz crystal blanks (Quartz Crystal Goblet Blank, Lead Crystal Decanter Blank, Celestial Void Starlight Flacon), engraved glassware recipes (Chalice of Sovereign Vitality, Decanter of Arcane Clarity, Celestial Void Reliquary Flacon), runic resonance ratings (0% to 100%), spell empower and mana conservation scaling, upfront material deduction on all attempts, consistent remainingProvidedBlanks shapes across all branches, and engraving lathe maintenance for OpenAO MMORPG.

Features

• Engraving lathe catalog with power ratings, durability, and sigil bonuses
• Engraved glassware recipes with clamped spell empower and mana conservation scaling
• Independent runic resonance quality roll scaling
• Upfront material deduction on all craft attempts to prevent zero-cost retries
• Consistent remainingProvidedBlanks arrays returned on all early rejection branches
• Cached static catalog maxima and table maintenance with durability threshold gating
• Full unit test coverage under Vitest

[gitar-bot]

Code Review ✅ Approved 2 resolved / 2 findings

Adds ancient runic glass engraving lathe, copper wheel intaglio, and arcane sigil crafting system with engraving lathes, raw quartz blanks, engraved glassware recipes, and runic resonance ratings. Resolved the finalSpellEmpowerPercent cap hiding top-tier Celestial quality and added mid-range resonance quality multiplier test coverage. No issues remain.

✅ 2 resolved

✅ Bug: finalSpellEmpowerPercent cap hides top-tier Celestial quality

📄 api/src/lib/ancientRunicGlassEngravingLathe.ts:200-202
For CELESTIAL_VOID_RELIQUARY_FLACON (baseSpellEmpowerPercent 85), the quality multiplier can reach 1.2, giving 85*1.2=102 which is clamped to 100. This means the entire top band of runic resonance produces an identical 100% empower, so higher-quality crafts are indistinguishable at the top end. If differentiation at high resonance is desired, lower the base or raise the clamp; if the flattening is intentional this is fine as-is.

✅ Quality: No test covers mid-range resonance / quality multiplier

📄 api/src/tests/ancientRunicGlassEngravingLathe.test.ts:8-22 📄 api/src/tests/ancientRunicGlassEngravingLathe.test.ts:81-95 📄 api/src/lib/ancientRunicGlassEngravingLathe.ts:193-203
The tests only exercise resonanceRoll=1.0 (forcing a 100% resonance, 1.2x multiplier) on success, plus failure/rejection paths. No test verifies a successful craft with partial resonance where the qualityMultiplier is < 1.2 (e.g. a CEDAR lathe with a mid-range resonanceRoll), so the powerRatio/bonusPoints scaling and the 0.8-1.2 multiplier interpolation are never validated for non-maximal inputs. Add a case asserting a specific sub-100 runicResonancePercent and the resulting scaled empower/conservation to lock in that math.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

---

Important

Your trial ends in 1 day — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

_{Was this helpful? React with 👍 / 👎 | Gitar}