Skip to content

feat(glaziery): ancient runic glass hourglass sand caster, chronomantic crucible, and temporal flow engine - #286

Open
angelTomo9 wants to merge 2 commits into
Bitcoindefi:mainfrom
angelTomo9:feat-hourglass-caster-1788150655121
Open

feat(glaziery): ancient runic glass hourglass sand caster, chronomantic crucible, and temporal flow engine#286
angelTomo9 wants to merge 2 commits into
Bitcoindefi:mainfrom
angelTomo9:feat-hourglass-caster-1788150655121

Conversation

@angelTomo9

Copy link
Copy Markdown

Summary

Implements an ancient runic glass hourglass sand caster, chronomantic crucible calibration stand, and temporal flow clepsydra crafting system, hourglass stands (Cedar Hourglass Caster Stand, Runic Brass Chronomantic Gimbal, Celestial Void Chronos Flow Sanctum), raw fused quartz glass bulbs (Fused Quartz Glass Bulb, Chronomantic Gold Sand Phial, Celestial Void Temporal Stardust Ampoule), temporal hourglass recipes (Wanderer Chrono-Tether Hourglass, Time-Warp Spell-Haste Sandglass, Celestial Void Chronos Epoch Clepsydra), temporal precision ratings (scaled across catalog baselines ~14% to 100%), calibrated cooldown reduction aura and haste flow duration scaling, upfront material deduction on all attempts, consistent remainingProvidedBulbs shapes across all branches, extensionless test import, and hourglass stand maintenance for OpenAO MMORPG.

Features

  • Hourglass stand catalog with power ratings, durability, and temporal bonuses
  • Temporal hourglass recipes with calibrated cooldown reduction aura and haste flow duration scaling
  • Independent temporal precision quality roll scaling
  • Upfront material deduction on all craft attempts to prevent zero-cost retries
  • Consistent remainingProvidedBulbs arrays returned on all early rejection branches
  • Cached static catalog maxima and table maintenance with durability threshold gating
  • Full unit test coverage under Vitest including mid-range precision tests

Comment thread api/src/lib/ancientRunicGlassHourglassSandCaster.ts
@gitar-bot

gitar-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 resolved / 1 findings

Adds a temporal hourglass crafting system with hourglass stands, raw fused quartz glass bulbs, and temporal hourglass recipes, along with calibrated cooldown reduction and haste flow duration scaling. Fixes the ignored chronomanticPower field on active stands to use catalog values consistently.

✅ 1 resolved
Quality: Live stand.chronomanticPower ignored; catalog value used instead

📄 api/src/lib/ancientRunicGlassHourglassSandCaster.ts:32-40 📄 api/src/lib/ancientRunicGlassHourglassSandCaster.ts:195
castHourglass computes powerRatio from standData.chronomanticPower (the static catalog value) rather than the live stand.chronomanticPower on the ActiveHourglassStand instance. This makes the instance's chronomanticPower field effectively dead for craft calculations, so any runtime buff/debuff/upgrade stored on the stand has no effect on temporal precision. If catalog values are intended to be authoritative (as the doc comment states), consider removing chronomanticPower from ActiveHourglassStand to avoid a misleading dead field; otherwise read from stand.chronomanticPower.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Important

Your trial ends in 1 day — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant