feat(glaziery): ancient runic glass acid etching vat, fluorite acid bath, and frosted sigil engine - #288
Open
angelTomo9 wants to merge 1 commit into
Open
Conversation
…id bath, and frosted sigil engine
Code Review ✅ ApprovedImplements an ancient runic glass acid etching vat, fluorite acid bath, and frosted sigil glassware crafting system with acid vats, frosted glassware recipes, opacity ratings, curse resistance and mana barrier shielding scaling, upfront material deduction, and full unit test coverage. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 1 day — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements an ancient runic glass acid etching vat, fluorite acid bath, and frosted sigil glassware crafting system, acid vats (Cedar Acid Etching Vat, Runic Lead-Lined Fluorite Tank, Celestial Void Hydrofluoric Sanctum), raw lead crystal carafes and beeswax resists (Lead Crystal Carafe Blank, Beeswax Pattern Resist Slab, Celestial Void Starlight Decanter Vessel), frosted glassware recipes (Frosted Decanter of Spirit Warding, Acid-Etched Dragon Phylactery, Celestial Void Seraphic Frosted Urn), frosted opacity ratings (scaled across catalog baselines ~14% to 100%), calibrated curse resistance and mana barrier shielding scaling, upfront material deduction on all attempts, consistent remainingProvidedVessels shapes across all branches, extensionless test import, crypto-secure default gameplay rolls, and acid vat maintenance for OpenAO MMORPG.
Features