Skip to content

feat(glaziery): ancient runic glass acid etching vat, fluorite acid bath, and frosted sigil engine - #288

Open
angelTomo9 wants to merge 1 commit into
Bitcoindefi:mainfrom
angelTomo9:feat-acid-etching-1788151857085
Open

feat(glaziery): ancient runic glass acid etching vat, fluorite acid bath, and frosted sigil engine#288
angelTomo9 wants to merge 1 commit into
Bitcoindefi:mainfrom
angelTomo9:feat-acid-etching-1788151857085

Conversation

@angelTomo9

Copy link
Copy Markdown

Summary

Implements an ancient runic glass acid etching vat, fluorite acid bath, and frosted sigil glassware crafting system, acid vats (Cedar Acid Etching Vat, Runic Lead-Lined Fluorite Tank, Celestial Void Hydrofluoric Sanctum), raw lead crystal carafes and beeswax resists (Lead Crystal Carafe Blank, Beeswax Pattern Resist Slab, Celestial Void Starlight Decanter Vessel), frosted glassware recipes (Frosted Decanter of Spirit Warding, Acid-Etched Dragon Phylactery, Celestial Void Seraphic Frosted Urn), frosted opacity ratings (scaled across catalog baselines ~14% to 100%), calibrated curse resistance and mana barrier shielding scaling, upfront material deduction on all attempts, consistent remainingProvidedVessels shapes across all branches, extensionless test import, crypto-secure default gameplay rolls, and acid vat maintenance for OpenAO MMORPG.

Features

  • Acid etching vat catalog with power ratings, durability, and frosted bonuses
  • Frosted glassware recipes with calibrated curse resistance and mana barrier shielding scaling
  • Independent frosted opacity quality roll scaling
  • Upfront material deduction on all craft attempts to prevent zero-cost retries
  • Consistent remainingProvidedVessels arrays returned on all early rejection branches
  • Cached static catalog maxima and table maintenance with durability threshold gating
  • Full unit test coverage under Vitest including mid-range opacity tests

@gitar-bot

gitar-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Implements an ancient runic glass acid etching vat, fluorite acid bath, and frosted sigil glassware crafting system with acid vats, frosted glassware recipes, opacity ratings, curse resistance and mana barrier shielding scaling, upfront material deduction, and full unit test coverage. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Important

Your trial ends in 1 day — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant