Skip to content

feat(leathercraft): ancient runic leather bellows forge craft, oxhide valve, and blast engine - #292

Open
angelTomo9 wants to merge 1 commit into
Bitcoindefi:mainfrom
angelTomo9:feat-bellows-forge-1788154246176
Open

feat(leathercraft): ancient runic leather bellows forge craft, oxhide valve, and blast engine#292
angelTomo9 wants to merge 1 commit into
Bitcoindefi:mainfrom
angelTomo9:feat-bellows-forge-1788154246176

Conversation

@angelTomo9

Copy link
Copy Markdown

Summary

Implements an ancient runic leather bellows forge craft, oxhide air chamber valve, and blast furnace bellows crafting system, bellows benches (Oak Bellows Framing Bench, Runic Ironwood Double-Lung Bellows Rig, Celestial Void Seraphic Blast Sanctum), raw tanned oxhide diaphragms and cast brass blast tuyere nozzles (Tanned Oxhide Bellows Diaphragm, Cast Brass Blast Tuyere Nozzle, Celestial Void Starlight Pneumatic Leather), blast furnace bellows recipes (Apprentice Forge-Breeze Bellows, Master Crucible Air-Blast Bellows, Celestial Void Seraphic Pneumatic Forge Engine), blast pressure ratings (scaled across catalog baselines ~14% to 100%), calibrated forge smelting speed and ingot yield purity scaling, upfront material deduction on all attempts, consistent remainingProvidedLeathers shapes across all branches, extensionless test import, crypto-secure default gameplay rolls strictly in [0, 1), and bellows bench maintenance for OpenAO MMORPG.

Features

  • Bellows bench catalog with power ratings, durability, and blast bonuses
  • Blast furnace bellows recipes with calibrated forge smelting speed and ingot yield purity scaling
  • Independent blast pressure quality roll scaling
  • Upfront material deduction on all craft attempts to prevent zero-cost retries
  • Consistent remainingProvidedLeathers arrays returned on all early rejection branches
  • Cached static catalog maxima and table maintenance with durability threshold gating
  • Full unit test coverage under Vitest including mid-range pressure tests

@gitar-bot

gitar-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Implements an ancient runic leather bellows forge craft system for OpenAO MMORPG, including bellows benches with power ratings and durability, blast furnace bellows recipes with calibrated smelting speed and ingot yield scaling, pressure quality rolls, upfront material deduction to prevent zero-cost retries, and full unit test coverage. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Important

Your trial ends in 1 day — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant