feat(leathercraft): ancient runic leather bellows forge craft, oxhide valve, and blast engine - #292
Open
angelTomo9 wants to merge 1 commit into
Open
Conversation
…hide valve, and blast engine
Code Review ✅ ApprovedImplements an ancient runic leather bellows forge craft system for OpenAO MMORPG, including bellows benches with power ratings and durability, blast furnace bellows recipes with calibrated smelting speed and ingot yield scaling, pressure quality rolls, upfront material deduction to prevent zero-cost retries, and full unit test coverage. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 1 day — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements an ancient runic leather bellows forge craft, oxhide air chamber valve, and blast furnace bellows crafting system, bellows benches (Oak Bellows Framing Bench, Runic Ironwood Double-Lung Bellows Rig, Celestial Void Seraphic Blast Sanctum), raw tanned oxhide diaphragms and cast brass blast tuyere nozzles (Tanned Oxhide Bellows Diaphragm, Cast Brass Blast Tuyere Nozzle, Celestial Void Starlight Pneumatic Leather), blast furnace bellows recipes (Apprentice Forge-Breeze Bellows, Master Crucible Air-Blast Bellows, Celestial Void Seraphic Pneumatic Forge Engine), blast pressure ratings (scaled across catalog baselines ~14% to 100%), calibrated forge smelting speed and ingot yield purity scaling, upfront material deduction on all attempts, consistent remainingProvidedLeathers shapes across all branches, extensionless test import, crypto-secure default gameplay rolls strictly in [0, 1), and bellows bench maintenance for OpenAO MMORPG.
Features