feat(leathercraft): ancient runic leather belt pouch bench, toggle clasp, and satchel engine

[angelTomo9]

Summary

Implements an ancient runic leather belt pouch bench, brass toggle clasp setting rig, and alchemical reagent pouch crafting system, pouch benches (Oak Pouch Stitching Bench, Runic Ironwood Reagent Pouch Rig, Celestial Void Seraphic Satchel Sanctum), raw tanned calfskin and polished brass toggle clasps (Tanned Calfskin Pouch Blank, Polished Brass Toggle Clasp, Celestial Void Starlight Alchemical Leather), alchemical belt pouch recipes (Adventurer Quick-Access Belt Pouch, Alchemist Spill-Proof Herb Pouch, Celestial Void Seraphic Bottomless Satchel), quick-draw accessibility ratings (scaled across catalog baselines ~14% to 100%), calibrated potion cooldown reduction and herb freshness preservation scaling, upfront material deduction on all attempts, consistent remainingProvidedLeathers shapes across all branches, immutable bench cloning for safe rollbacks, extensionless test import, crypto-secure default gameplay rolls strictly in [0, 1), and pouch bench maintenance for OpenAO MMORPG.

Features

• Pouch bench catalog with power ratings, durability, and quickdraw bonuses
• Alchemical belt pouch recipes with calibrated potion cooldown reduction and herb freshness preservation scaling
• Independent quick-draw accessibility quality roll scaling
• Upfront material deduction on all craft attempts to prevent zero-cost retries
• Consistent remainingProvidedLeathers arrays returned on all early rejection branches
• Immutable bench cloning pattern to safeguard caller state references
• Cached static catalog maxima and table maintenance with durability threshold gating
• Full unit test coverage under Vitest including mid-range accessibility tests

[gitar-bot]

Code Review ✅ Approved 1 resolved / 1 findings

Adds ancient runic leather belt pouch bench, toggle clasp, and satchel engine with pouch bench catalog, calibrated recipes, and quick-draw accessibility scaling. Fixes maintainBench to clone the bench for immutable input safety. No issues found.

✅ 1 resolved

✅ Quality: maintainBench mutates input bench, breaking immutability contract

📄 api/src/lib/ancientRunicLeatherBeltPouchBench.ts:242-256
The module documents an immutable bench cloning pattern and craftPouch honors it by cloning ({ ...bench }), but maintainBench mutates the caller's bench object in place (bench.currentDurability and bench.isFunctional). This inconsistency means maintenance alters caller state and cannot be rolled back like craft attempts. Consider cloning the bench and returning the updated clone to match craftPouch semantics.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

---

Important

Your trial ends in 1 day — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

_{Was this helpful? React with 👍 / 👎 | Gitar}