feat(leathercraft): ancient runic leather tome binding bench, gold leaf wheel, and grimoire engine - #295
Open
angelTomo9 wants to merge 1 commit into
Open
Conversation
…d leaf wheel, and grimoire engine
Code Review ✅ ApprovedImplements ancient runic leather tome binding bench, gold leaf tooling wheel, and grimoire engine system with tome bench catalog, spellbook recipes, mana conductivity scaling, and upfront material deduction to prevent zero-cost retries. Includes immutable bench cloning for safe state management and full unit test coverage. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 1 day — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements an ancient runic leather tome binding bench, gold leaf tooling wheel, and arcane grimoire crafting system, tome benches (Oak Tome Binding Press, Runic Ironwood Gold Leaf Tooling Wheel, Celestial Void Seraphic Grimoire Sanctum), raw tanned calfskin vellum and burnished gold tooling foils (Tanned Calfskin Vellum Folio, Burnished Gold Leaf Tooling Foil, Celestial Void Starlight Chronomantic Leather), spellbook tome recipes (Apprentice Cantrip Spellbook, Archmage Prismatic Grimoire, Celestial Void Seraphic Chronomantic Tome), mana conductivity ratings (scaled across catalog baselines ~14% to 100%), calibrated spell mana cost reduction and spell critical magnitude scaling, upfront material deduction on all attempts, consistent remainingProvidedLeathers shapes across all branches, immutable bench cloning for safe rollbacks on craft and maintain operations, extensionless test import, crypto-secure default gameplay rolls strictly in [0, 1), and tome bench maintenance for OpenAO MMORPG.
Features