feat(leathercraft): ancient runic leather flask holster bench, stopper strap, and elixir engine - #296
Open
angelTomo9 wants to merge 1 commit into
Open
Conversation
…opper strap, and elixir engine
Code Review ✅ ApprovedImplements a comprehensive ancient runic leather flask holster bench, stopper strap, and elixir engine system for the OpenAO MMORPG, including bench catalogs with power ratings, calibrated potion efficacy and shatter mitigation scaling, independent delivery fluidity rolls, upfront material deduction, and immutable bench cloning patterns. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 1 day — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements an ancient runic leather flask holster bench, cork stopper strap rig, and elixir harness crafting system, holster benches (Oak Flask Holster Bench, Runic Ironwood Alchemy Harness Rig, Celestial Void Seraphic Elixir Sanctum), raw tanned goatskin and waxed cork stopper straps (Tanned Goatskin Holster Blank, Waxed Cork Stopper Strap, Celestial Void Starlight Alchemical Harness Leather), elixir holster recipes (Scout Quick-Sip Flask Holster, Combat Medic Double-Vial Harness, Celestial Void Seraphic Bottomless Elixir Rig), delivery fluidity ratings (scaled across catalog baselines ~14% to 100%), calibrated potion efficacy bonus and potion shatter mitigation scaling, upfront material deduction on all attempts, consistent remainingProvidedLeathers shapes across all branches, immutable bench cloning on craft and maintain operations, extensionless test import, crypto-secure default gameplay rolls strictly in [0, 1), and holster bench maintenance for OpenAO MMORPG.
Features