feat(leathercraft): ancient runic leather shield strapping bench, rivet buckle, and aegis engine - #297
Open
angelTomo9 wants to merge 1 commit into
Open
Conversation
… rivet buckle, and aegis engine
Code Review ✅ ApprovedImplements a shield strapping bench crafting system with combat shield harness recipes, poise recovery mechanics, and material management. The feature includes bench catalog entries, calibrated block poise recovery and stamina drain mitigation scaling, upfront material deduction to prevent zero-cost retries, immutable bench cloning, and comprehensive unit test coverage. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 1 day — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements an ancient runic leather shield strapping bench, iron rivet buckle anvil, and combat shield harness crafting system, shield strapping benches (Oak Shield Strapping Bench, Runic Ironwood Aegis Harness Rig, Celestial Void Seraphic Bulwark Sanctum), raw tanned bullhide enarme straps and tempered steel buckle plates (Tanned Bullhide Enarme Strap, Tempered Steel Buckle Plate, Celestial Void Starlight Aegis Leather), shield strap harness recipes (Skirmisher Fast-Pivot Buckler Strap, Guardian Heavy Tower Shield Enarme, Celestial Void Seraphic Bulwark Harness), poise recovery fluidity ratings (scaled across catalog baselines ~14% to 100%), calibrated block poise recovery and shield break stamina drain mitigation scaling, upfront material deduction on all attempts, consistent remainingProvidedLeathers shapes across all branches, immutable bench cloning on craft and maintain operations, extensionless test import, crypto-secure default gameplay rolls strictly in [0, 1), and shield bench maintenance for OpenAO MMORPG.
Features