Skip to content

feat(leathercraft): ancient runic leather armory dummy bench, straw stuffer, and target engine - #298

Open
angelTomo9 wants to merge 1 commit into
Bitcoindefi:mainfrom
angelTomo9:feat-armory-dummy-1788157846218
Open

feat(leathercraft): ancient runic leather armory dummy bench, straw stuffer, and target engine#298
angelTomo9 wants to merge 1 commit into
Bitcoindefi:mainfrom
angelTomo9:feat-armory-dummy-1788157846218

Conversation

@angelTomo9

Copy link
Copy Markdown

Summary

Implements an ancient runic leather armory dummy bench, straw core compressor rig, and training target crafting system, dummy benches (Oak Armory Dummy Bench, Runic Ironwood Sparring Rig, Celestial Void Seraphic Automaton Sanctum), raw tanned horsehide dummy skins and enchanted straw core bundles (Tanned Horsehide Dummy Skin, Enchanted Straw Core Bundle, Celestial Void Starlight Training Leather), training dummy recipes (Novice Straw-Filled Target Dummy, Veteran Iron-Reinforced Sparring Dummy, Celestial Void Seraphic Dynamic Automaton), impact resilience and weapon rebound ratings (scaled across catalog baselines ~14% to 100%), calibrated training XP gain multiplier and weapon wear mitigation scaling, upfront material deduction on all attempts, consistent remainingProvidedLeathers shapes across all branches, immutable bench cloning on craft and maintain operations, extensionless test import, crypto-secure default gameplay rolls strictly in [0, 1), and dummy bench maintenance for OpenAO MMORPG.

Features

  • Dummy bench catalog with power ratings, durability, and rebound bonuses
  • Training dummy recipes with calibrated training XP gain and weapon wear mitigation scaling
  • Independent impact resilience quality roll scaling
  • Upfront material deduction on all craft attempts to prevent zero-cost retries
  • Consistent remainingProvidedLeathers arrays returned on all early rejection branches
  • Immutable bench cloning pattern across craft and maintain functions to safeguard caller state references
  • Cached static catalog maxima and table maintenance with durability threshold gating
  • Full unit test coverage under Vitest including mid-range resilience tests

@gitar-bot

gitar-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Implements an ancient runic leather armory system with dummy benches, training dummies, and crafting recipes for the OpenAO MMORPG. Features include calibrated training XP multipliers, weapon wear mitigation, impact resilience scaling, upfront material deduction to prevent zero-cost retries, immutable bench cloning, and full unit test coverage. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Important

Your trial ends in 1 day — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant