feat(leathercraft): ancient runic leather armory dummy bench, straw stuffer, and target engine - #298
Open
angelTomo9 wants to merge 1 commit into
Open
Conversation
…aw stuffer, and target engine
Code Review ✅ ApprovedImplements an ancient runic leather armory system with dummy benches, training dummies, and crafting recipes for the OpenAO MMORPG. Features include calibrated training XP multipliers, weapon wear mitigation, impact resilience scaling, upfront material deduction to prevent zero-cost retries, immutable bench cloning, and full unit test coverage. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 1 day — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements an ancient runic leather armory dummy bench, straw core compressor rig, and training target crafting system, dummy benches (Oak Armory Dummy Bench, Runic Ironwood Sparring Rig, Celestial Void Seraphic Automaton Sanctum), raw tanned horsehide dummy skins and enchanted straw core bundles (Tanned Horsehide Dummy Skin, Enchanted Straw Core Bundle, Celestial Void Starlight Training Leather), training dummy recipes (Novice Straw-Filled Target Dummy, Veteran Iron-Reinforced Sparring Dummy, Celestial Void Seraphic Dynamic Automaton), impact resilience and weapon rebound ratings (scaled across catalog baselines ~14% to 100%), calibrated training XP gain multiplier and weapon wear mitigation scaling, upfront material deduction on all attempts, consistent remainingProvidedLeathers shapes across all branches, immutable bench cloning on craft and maintain operations, extensionless test import, crypto-secure default gameplay rolls strictly in [0, 1), and dummy bench maintenance for OpenAO MMORPG.
Features