feat(leathercraft): ancient runic leather tent canopy bench, awl, and camp shelter engine - #300
Open
angelTomo9 wants to merge 1 commit into
Open
Conversation
… and camp shelter engine
Code Review ✅ ApprovedImplements a comprehensive leathercraft system for OpenAO MMORPG with canopy benches, expedition recipes, and camp shelter crafting mechanics. Features include calibrated weather resistance, rest recovery scaling, upfront material deduction to prevent zero-cost retries, immutable bench cloning for state safety, and full test coverage. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 1 day — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements an ancient runic leather tent canopy bench, waxed seam awl frame, and camp shelter crafting system, canopy benches (Oak Tent Canopy Bench, Runic Ironwood Pavilion Rig, Celestial Void Seraphic Shelter Sanctum), raw tanned mammoth hide canopies and waxed heavy hemp threads (Tanned Mammoth Hide Canopy, Waxed Heavy Hemp Thread, Celestial Void Starlight Sovereign Pavilion Leather), expedition canopy recipes (Scout Fast-Pitch Shelter Canopy, Guild Veteran Weatherproof Pavilion, Celestial Void Seraphic Fortress Canopy), rest recovery ratings (scaled across catalog baselines ~14% to 100%), calibrated elemental weather resistance and camp rest recovery scaling, upfront material deduction on all attempts, consistent remainingProvidedLeathers shapes across all branches, immutable bench cloning on craft and maintain operations, extensionless test import, crypto-secure default gameplay rolls strictly in [0, 1), and canopy bench maintenance for OpenAO MMORPG.
Features