Skip to content

feat(leathercraft): ancient runic leather tent canopy bench, awl, and camp shelter engine - #300

Open
angelTomo9 wants to merge 1 commit into
Bitcoindefi:mainfrom
angelTomo9:feat-tent-canopy-1788159055112
Open

feat(leathercraft): ancient runic leather tent canopy bench, awl, and camp shelter engine#300
angelTomo9 wants to merge 1 commit into
Bitcoindefi:mainfrom
angelTomo9:feat-tent-canopy-1788159055112

Conversation

@angelTomo9

Copy link
Copy Markdown

Summary

Implements an ancient runic leather tent canopy bench, waxed seam awl frame, and camp shelter crafting system, canopy benches (Oak Tent Canopy Bench, Runic Ironwood Pavilion Rig, Celestial Void Seraphic Shelter Sanctum), raw tanned mammoth hide canopies and waxed heavy hemp threads (Tanned Mammoth Hide Canopy, Waxed Heavy Hemp Thread, Celestial Void Starlight Sovereign Pavilion Leather), expedition canopy recipes (Scout Fast-Pitch Shelter Canopy, Guild Veteran Weatherproof Pavilion, Celestial Void Seraphic Fortress Canopy), rest recovery ratings (scaled across catalog baselines ~14% to 100%), calibrated elemental weather resistance and camp rest recovery scaling, upfront material deduction on all attempts, consistent remainingProvidedLeathers shapes across all branches, immutable bench cloning on craft and maintain operations, extensionless test import, crypto-secure default gameplay rolls strictly in [0, 1), and canopy bench maintenance for OpenAO MMORPG.

Features

  • Canopy bench catalog with power ratings, durability, and rest bonuses
  • Expedition canopy recipes with calibrated weather resistance and camp rest recovery scaling
  • Independent rest recovery quality roll scaling
  • Upfront material deduction on all craft attempts to prevent zero-cost retries
  • Consistent remainingProvidedLeathers arrays returned on all early rejection branches
  • Immutable bench cloning pattern across craft and maintain functions to safeguard caller state references
  • Cached static catalog maxima and table maintenance with durability threshold gating
  • Full unit test coverage under Vitest including mid-range rest recovery tests

@gitar-bot

gitar-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Implements a comprehensive leathercraft system for OpenAO MMORPG with canopy benches, expedition recipes, and camp shelter crafting mechanics. Features include calibrated weather resistance, rest recovery scaling, upfront material deduction to prevent zero-cost retries, immutable bench cloning for state safety, and full test coverage. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Important

Your trial ends in 1 day — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant