feat(leathercraft): ancient runic leather saddle bag bench, rivet buckle, and mount haversack engine - #302
Open
angelTomo9 wants to merge 1 commit into
Open
Conversation
… buckle, and mount haversack engine
Code Review ✅ ApprovedImplements a comprehensive leathercraft system for OpenAO MMORPG with saddle bag benches, rivet buckle crafting, and mount haversack recipes. Features include calibrated carrying capacity bonuses, stamina mitigation scaling, immutable bench cloning to prevent state corruption, upfront material deduction, and consistent quick-loot accessibility ratings. Full unit test coverage included. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 1 day — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements an ancient runic leather saddle bag bench, brass rivet buckle anvil, and mount pannier crafting system, saddle bag benches (Oak Saddle Bag Bench, Runic Ironwood Mount Rig, Celestial Void Seraphic Caravan Sanctum), raw tanned horsehide pannier blanks and brass riveted buckle sets (Tanned Horsehide Pannier Blank, Brass Riveted Buckle Set, Celestial Void Starlight Sovereign Caravan Leather), mount saddle bag recipes (Courier Fast-Access Saddle Bag, Caravan Heavy Double Pannier, Celestial Void Seraphic Dimension-Folded Mount Haversack), quick-loot accessibility ratings (scaled across catalog baselines ~14% to 100%), calibrated mount carrying capacity bonus and stamina depletion mitigation scaling, upfront material deduction on all attempts, consistent remainingProvidedLeathers shapes across all branches, immutable bench cloning on craft and maintain operations, extensionless test import with import type separation, crypto-secure default gameplay rolls strictly in [0, 1), and saddle bag bench maintenance for OpenAO MMORPG.
Features