Skip to content

feat(leathercraft): ancient runic leather saddle bag bench, rivet buckle, and mount haversack engine - #302

Open
angelTomo9 wants to merge 1 commit into
Bitcoindefi:mainfrom
angelTomo9:feat-saddle-bag-1788160262511
Open

feat(leathercraft): ancient runic leather saddle bag bench, rivet buckle, and mount haversack engine#302
angelTomo9 wants to merge 1 commit into
Bitcoindefi:mainfrom
angelTomo9:feat-saddle-bag-1788160262511

Conversation

@angelTomo9

Copy link
Copy Markdown

Summary

Implements an ancient runic leather saddle bag bench, brass rivet buckle anvil, and mount pannier crafting system, saddle bag benches (Oak Saddle Bag Bench, Runic Ironwood Mount Rig, Celestial Void Seraphic Caravan Sanctum), raw tanned horsehide pannier blanks and brass riveted buckle sets (Tanned Horsehide Pannier Blank, Brass Riveted Buckle Set, Celestial Void Starlight Sovereign Caravan Leather), mount saddle bag recipes (Courier Fast-Access Saddle Bag, Caravan Heavy Double Pannier, Celestial Void Seraphic Dimension-Folded Mount Haversack), quick-loot accessibility ratings (scaled across catalog baselines ~14% to 100%), calibrated mount carrying capacity bonus and stamina depletion mitigation scaling, upfront material deduction on all attempts, consistent remainingProvidedLeathers shapes across all branches, immutable bench cloning on craft and maintain operations, extensionless test import with import type separation, crypto-secure default gameplay rolls strictly in [0, 1), and saddle bag bench maintenance for OpenAO MMORPG.

Features

  • Saddle bag bench catalog with power ratings, durability, and quickloot bonuses
  • Mount saddle bag recipes with calibrated carrying capacity and stamina mitigation scaling
  • Independent quick-loot accessibility quality roll scaling
  • Upfront material deduction on all craft attempts to prevent zero-cost retries
  • Consistent remainingProvidedLeathers arrays returned on all early rejection branches
  • Immutable bench cloning pattern across craft and maintain functions to safeguard caller state references
  • Cached static catalog maxima and table maintenance with durability threshold gating
  • Full unit test coverage under Vitest including mid-range accessibility tests

@gitar-bot

gitar-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Implements a comprehensive leathercraft system for OpenAO MMORPG with saddle bag benches, rivet buckle crafting, and mount haversack recipes. Features include calibrated carrying capacity bonuses, stamina mitigation scaling, immutable bench cloning to prevent state corruption, upfront material deduction, and consistent quick-loot accessibility ratings. Full unit test coverage included. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Important

Your trial ends in 1 day — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant