Skip to content

feat(leathercraft): ancient runic leather mask hood bench, nightshade dye, and assassin cowl engine - #303

Open
angelTomo9 wants to merge 1 commit into
Bitcoindefi:mainfrom
angelTomo9:feat-mask-hood-1788160844742
Open

feat(leathercraft): ancient runic leather mask hood bench, nightshade dye, and assassin cowl engine#303
angelTomo9 wants to merge 1 commit into
Bitcoindefi:mainfrom
angelTomo9:feat-mask-hood-1788160844742

Conversation

@angelTomo9

Copy link
Copy Markdown

Summary

Implements an ancient runic leather mask hood bench, nightshade dye vat frame, and assassin cowl crafting system, mask benches (Oak Mask Hood Bench, Runic Ironwood Stalker Rig, Celestial Void Seraphic Shadow Sanctum), raw tanned shadowcat hide mask blanks and concentrated nightshade dye cakes (Tanned Shadowcat Hide Mask Blank, Concentrated Nightshade Dye Cake, Celestial Void Starlight Assassin Leather), assassin mask and cowl recipes (Rogue Shadow-Stalker Mask, Assassin Night-Veil Cowl, Celestial Void Seraphic Phantom Eclipse Hood), shadow concealment ratings (scaled across catalog baselines ~14% to 100%), calibrated sneak attack damage bonus and stealth detection radius reduction scaling, upfront material deduction on all attempts, consistent remainingProvidedLeathers shapes across all branches, immutable bench cloning on craft and maintain operations, extensionless test import with import type separation, crypto-secure default gameplay rolls strictly in [0, 1), and mask bench maintenance for OpenAO MMORPG.

Features

  • Mask bench catalog with power ratings, durability, and concealment bonuses
  • Assassin mask recipes with calibrated sneak attack damage and detection radius reduction scaling
  • Independent shadow concealment quality roll scaling
  • Upfront material deduction on all craft attempts to prevent zero-cost retries
  • Consistent remainingProvidedLeathers arrays returned on all early rejection branches
  • Immutable bench cloning pattern across craft and maintain functions to safeguard caller state references
  • Cached static catalog maxima and table maintenance with durability threshold gating
  • Full unit test coverage under Vitest including mid-range concealment tests

@gitar-bot

gitar-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Implements an ancient runic leather mask hood bench system with nightshade dye vats and assassin cowl crafting recipes, including mask bench catalogs with concealment bonuses, calibrated sneak attack damage scaling, upfront material deduction on craft attempts, and immutable bench cloning to safeguard state. Full unit test coverage included. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Important

Your trial ends in 1 day — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant