feat(leathercraft): ancient runic leather mask hood bench, nightshade dye, and assassin cowl engine - #303
Open
angelTomo9 wants to merge 1 commit into
Open
Conversation
…hade dye, and assassin cowl engine
Code Review ✅ ApprovedImplements an ancient runic leather mask hood bench system with nightshade dye vats and assassin cowl crafting recipes, including mask bench catalogs with concealment bonuses, calibrated sneak attack damage scaling, upfront material deduction on craft attempts, and immutable bench cloning to safeguard state. Full unit test coverage included. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 1 day — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements an ancient runic leather mask hood bench, nightshade dye vat frame, and assassin cowl crafting system, mask benches (Oak Mask Hood Bench, Runic Ironwood Stalker Rig, Celestial Void Seraphic Shadow Sanctum), raw tanned shadowcat hide mask blanks and concentrated nightshade dye cakes (Tanned Shadowcat Hide Mask Blank, Concentrated Nightshade Dye Cake, Celestial Void Starlight Assassin Leather), assassin mask and cowl recipes (Rogue Shadow-Stalker Mask, Assassin Night-Veil Cowl, Celestial Void Seraphic Phantom Eclipse Hood), shadow concealment ratings (scaled across catalog baselines ~14% to 100%), calibrated sneak attack damage bonus and stealth detection radius reduction scaling, upfront material deduction on all attempts, consistent remainingProvidedLeathers shapes across all branches, immutable bench cloning on craft and maintain operations, extensionless test import with import type separation, crypto-secure default gameplay rolls strictly in [0, 1), and mask bench maintenance for OpenAO MMORPG.
Features