redo search normalization and cleanup request generation - #4
Open
AllergicSquare wants to merge 4 commits into
Open
redo search normalization and cleanup request generation#4AllergicSquare wants to merge 4 commits into
AllergicSquare wants to merge 4 commits into
Conversation
- switched from SanitizedSearchTerm to raw SearchTerm - moved normalization into the ABB provider - reworked normalization logic (keep useful characters, strip unsupported/unknown characters) - removed references to unused 'capability' check this should (hopefully!) allow more successful search queries! tested with multiple queries that were unsupported before (e.g. search queries with apostrophes). possibly still strips useful characters that the abb search suports, but should be easy to change the logic. (feel free to let me know!)
…ightly audiobookbay requires a session cookie sometimes for some reason. search results also seem more limited in these cases. might be rate limiting?
Author
|
i pushed another commit that makes the search url scheme the same as when doing searches on the site manually. i also added the session cookie parameter to the search requests, since the search sometimes returned no results without them. i took at the cookie handling of other prowlarr indexers for this. maybe it can be handled better. the only issue i can think of is that a valid search can take a bit longer, if you searched something with no results before because it makes it fetch the session cookie again. also the first ever search takes a bit longer i guess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Benefits of this PR and context:
this should (hopefully!) allow more successful search queries!
How Has This Been Tested?
tested with multiple queries that were unsupported before (e.g. search queries with apostrophes). possibly still strips useful characters that the abb search supports, but it should be easy to change the logic. (feel free to let me know!)
Source / References:
n/a