test: add missing model and error code test coverage - #19
Closed
julianschiavo wants to merge 1 commit into
Closed
Conversation
fix: decode unknown DocumentationKind values as nil
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.invalidScoreto BridgeErrorCode exhaustive testNote
Low Risk
Low risk: behavior change is limited to
DocumentationEntryJSON decoding, making it more tolerant of unexpectedkindvalues; remaining changes are test-only and validate encoding failures for invalid floating-point scores.Overview
Makes model decoding more robust and expands edge-case test coverage.
DocumentationEntrynow implements a customDecodableinitializer that treats unrecognizedDocumentationKindraw values asnilinstead of failing decode.Tests are extended to include the previously-missing
.invalidScoreBridgeErrorCode, verify unknownkinddecoding behavior, and assert thatSearchResultwithNaN/infinityscores throws duringJSONEncoderencoding.Written by Cursor Bugbot for commit 09123a4. This will update automatically on new commits. Configure here.