feat(noslop): add redundant-comment lens and rename-aware change loading - #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
redundant-comment, backed by a deterministic pre-check ininternal/slop/precheck. It lexes Go source withgo/scannerandgo/parser, groups contiguous comment lines into the comment a reader actually sees, and flags only comment blocks the change added: a phrase restated in the next clause, a doc comment whose every informative word is already spelled by the declaration it documents, and a standalone comment whose words are all present in the adjacent code line. Indented code samples, blank-line-separated notes, and comments carrying constraints or rationale are left alone. The lens is registered ininternal/slop/lensesand documented in the taxonomy and README.internal/slop/engine/gitload.goswitches to--find-renames, carries a newBaselinePaththroughengine,risk,precheck, and the test floor, derives added/deleted counts from the same diff instead of a second--numstatpass, and demotes a non-identical rename toModified.internal/gitgainsOutput/OutputBareso blob and NUL-delimited stdout keeps trailing whitespace thatRunwould trim. The classifier now treats a rename as mechanical only when it preserves path category, extension, and Go build constraints, and scope expansion compares against the baseline path so a relocation is not read as new runtime or schema surface.corpus/results/2026-08-12-r5/records the round 5 capture, andnoslop evaluategains--case-setwith a content-digest manifest (corpus/case-sets/rounds-1-through-4.json) so the pre-expansion baseline and round 4 captures still score against the 32 cases they ran on.Loadnow accepts an explicit emptyexpected_findingsarray for clean negatives.Pipeline
Updates from git push no-mistakes
⏭️ **intent** - skipped
✅ **Rebase** - passed
✅ **Review** - completed
✅ **Test** - passed
✅ **Lint** - passed
✅ **Push** - passed