feat(amt-verify): add --packet-count for multi-packet one-shot verification - #4
Closed
kkroo wants to merge 2 commits into
Closed
feat(amt-verify): add --packet-count for multi-packet one-shot verification#4kkroo wants to merge 2 commits into
kkroo wants to merge 2 commits into
Conversation
…cation Replace recv_first_matching with recv_matching_packets so amt-verify can wait for N matching multicast packets before a successful one-shot shutdown. Report packet_count and byte_count in the JSON OneshotReport; reject --packet-count 0 at config validation. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Closing as superseded by #5. The active |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
--packet-countflag toamt-verifyso the one-shot verifier can wait for N matching multicast packets before a successful shutdown, instead of returning after the first match.Changes
--packet-countarg (default1); rejected at config validation if0.recv_first_matching→recv_matching_packets: accumulates matching packets up towant_count, trackingpacket_countandbyte_countwhile preserving the first matching packet forFirstPacketreporting.OneshotReportJSON now includespacket_countandbyte_count.Notes
Behavior is unchanged at the default
--packet-count 1.🤖 Generated with Claude Code