Skip to content

feat(amt-verify): add --packet-count for multi-packet one-shot verification - #4

Closed
kkroo wants to merge 2 commits into
mainfrom
omar/amt-update-ip-encap-resolved
Closed

feat(amt-verify): add --packet-count for multi-packet one-shot verification#4
kkroo wants to merge 2 commits into
mainfrom
omar/amt-update-ip-encap-resolved

Conversation

@kkroo

@kkroo kkroo commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a --packet-count flag to amt-verify so the one-shot verifier can wait for N matching multicast packets before a successful shutdown, instead of returning after the first match.

Changes

  • New --packet-count arg (default 1); rejected at config validation if 0.
  • recv_first_matchingrecv_matching_packets: accumulates matching packets up to want_count, tracking packet_count and byte_count while preserving the first matching packet for FirstPacket reporting.
  • OneshotReport JSON now includes packet_count and byte_count.

Notes

Behavior is unchanged at the default --packet-count 1.

🤖 Generated with Claude Code

kkroo and others added 2 commits May 23, 2026 09:03
…cation

Replace recv_first_matching with recv_matching_packets so amt-verify can
wait for N matching multicast packets before a successful one-shot shutdown.
Report packet_count and byte_count in the JSON OneshotReport; reject
--packet-count 0 at config validation.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@kkroo

kkroo commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

Closing as superseded by #5. The active blo-15657-amt-verify-image PR already carries the --packet-count loop plus packet_count/byte_count JSON fields while also adding the deployable image. Review findings and the missing multi-packet test are consolidated on #5 so there is one branch to fix and land.

@kkroo kkroo closed this Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant