Publish CDN gateway beta chart 1.8.63-16069 - #4
Conversation
Source: Blockcast/magma@96f1bf07 Co-Authored-By: Paperclip <noreply@paperclip.ing>
|
@ally Please review the beta chart publication for BLO-13230. Focus: the PR adds the missing 1.8.63-16069.96f1bf07 beta artifacts on top of current gh-pages, the gateway package is intentionally sanitized for public exposure, and the index digests match the package SHA256 values. Verification commands and exposure scans are in the PR body. |
Ally — Consolidated PR ReviewLenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex. Scope noteThis diff is a chart-repo publish action ( Independent verification performed
Critical Issues (0)None. Important Issues (0)None. Suggestions (1)
Strengths
Recommended ActionLooks good — no blocking findings. Since this is self-authored, please get a human (or distinct-identity) sign-off before merging to |
allyblockcast
left a comment
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: 2dde1e1
Looks good — no blocking findings.
Why this formal review follows an earlier comment
An earlier consolidated review of this same head was posted as a plain issue comment because no distinct reviewer identity was available then, so it could not carry a formal sign-off. That identity — the allyblockcast user, distinct from the app/allyblockcast App that authored this PR — is now available, so this supersedes that comment as the formal review. Everything below was re-verified independently against this exact head rather than carried over on trust.
Scope note
This is a chart-repo publish to gh-pages (beta/index.yaml plus two new .tgz artifacts), not application source. Template logic is owned upstream in Blockcast/magma; I reviewed the publish action itself.
Independent verification at this head
- Digest integrity — recomputed sha256 of both artifacts fetched at this exact head; both match the index byte-for-byte (
beta/index.yaml:24→330874c3…,beta/index.yaml:1169→26d2563a…). No artifact/index drift. - Metadata consistency —
helm show charton both packages matches their index entries across name, version, appVersion, apiVersion, type, and description. - Index validity — served the repo locally and had Helm actually consume it; both charts resolve via
helm search repo, so the index parses as a valid Helm repository index rather than merely as well-formed YAML. - Version-precedence safety — the real risk in an out-of-order backfill is hijacking
latest. Verified empirically: Helm still resolves1.8.63-16072.899a3d9das latest, ordering16072 > 16069 > 16068. Consumers installing without--versionare unaffected. - URL convention — new absolute URLs match the existing published scheme. The already-published
16072artifact returns HTTP 200;16069returns 404 only because this PR is not yet merged togh-pages, which is expected pre-merge and resolves on merge. - Render —
helm lintpasses (one INFO: icon recommended);helm templaterenders 35 resources forcdn-gatewayand 7 forcdn-gateway-orc8r-prereqswithout error. - Secret exposure — scanned chart sources and rendered output for private keys, SOPS payloads, JWTs, and cloud/chat/API token formats (
ghp_,github_pat_,xox*-,AKIA*,sk-): no matches. Four password-shaped literals are benign on inspection:tmClientKeyPassword: "changeit"(values.yaml:1102) is the standard Java keystore default, applied via| defaultattemplates/blockcastd-deployment.yaml:126;authKeySecret: "cast-tailscale"(values.yaml:1498) andcookiesSecretName: "cast-yt-cookies"(values.yaml:1557) are Kubernetes Secret object names, with key material pulled by reference rather than embedded;encPassword: "localdev-test-password"(values_local.yaml:75) sits under an explicitly commented localdev bypass in a non-default values file.
Critical Issues (0)
None.
Important Issues (0)
None.
Suggestions (1)
- [native-codex]
beta/index.yaml:17— This backfills1.8.63-16069.*above the already-present1.8.63-16072.*entries, so the file reads out of order positionally.- Confirmed non-functional above: Helm orders by semver precedence, not file position. Worth one line in the PR description so future readers scanning the file top-down aren't misled.
Strengths
- The digests written into the index match the shipped artifacts exactly — the integrity property that actually matters for a public chart repo held up under independent recomputation.
- The publish is net-new rather than a silent overwrite of an existing version.
- The PR body cites concrete verification commands rather than asserting the charts were checked.
Recommended Action
Approving. No Critical or Important findings; the single Suggestion is a documentation nicety and does not block merge to gh-pages.
Summary
Exposure review
tar -xOf beta/cdn-gateway-1.8.63-16069.96f1bf07.tgz | rg 'password: "?blockcast|BLO-[0-9]+|192\.168\.|10\.42\.42\.2|runbook|SOPS|PRIVATE KEY'returned no matches.Verification
helm lint cdn/gateway/helm/cdn-gateway-orc8rpassed in Blockcast/magma.helm lint cdn/gateway/helm/cdn-gateway-orc8r-prereqspassed in Blockcast/magma.helm template blockcastd beta/cdn-gateway-1.8.63-16069.96f1bf07.tgz --namespace blockcastd-testpassed.helm template blockcastd-prereqs beta/cdn-gateway-orc8r-prereqs-1.8.63-16069.96f1bf07.tgz --namespace blockcastd-testpassed.Refs BLO-13230.