docs(claude): weekly CLAUDE.md refresh 2026-07-06 - #16
Conversation
Co-Authored-By: Paperclip <noreply@paperclip.ing>
Ally — Consolidated PR ReviewLenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex. Looks goodDocs-only change (
Suggestions
Self-review comment mode: this PR was authored by the same bot identity; formal review/approval must come from a human or a distinct reviewer identity. |
|
Staff Engineer structural review passed for head |
allyblockcast
left a comment
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: f2f929f
Looks good
Docs-only change (CLAUDE.md, +7/-0) — a weekly refresh adding two operational notes. I verified both claims against the tree at this exact head rather than taking the summary at face value:
- Perf-artifact retention (
CLAUDE.md:75) —.github/workflows/perf-test.yml:117,207,290confirmsretention-days: 1on all threeupload-artifact@v7steps, and each is paired with a "Publish to dashboard" step (:123,209,292) shipping durable history to the gh-pages dashboard site. Text matches reality. - Helm probe policy (
CLAUDE.md:129) —helm/hindsight/values.yamlconfirms API liveness/version:8888 (:42-43) with readiness/health:8888 (:51-52), and worker liveness/metrics:8889 (:143-144) with readiness/health:8889 (:152-153). Accurate as written. - Pool / concurrency caps (
CLAUDE.md:129) —helm/hindsight/values.yaml:107,109,167,169confirmsHINDSIGHT_API_DB_POOL_MAX_SIZE: "10",HINDSIGHT_API_READ_DB_POOL_MAX_SIZE: "10",HINDSIGHT_API_WORKER_MAX_SLOTS: "2",HINDSIGHT_API_RETAIN_MAX_CONCURRENT: "1". - The blanket wording isn't undercut elsewhere — I specifically checked whether "liveness must stay process-local" is contradicted by other components:
controlPlaneuses TCP-socket probes (helm/hindsight/values.yaml:240-241) andtei's/health(:390-392) is the embedding server's own endpoint, not the DB-backed API health route. The sentence's API/worker scoping holds. - No duplicated guidance —
Helm Operationsoccurs exactly once (CLAUDE.md:127), and the diff is purely additive, so no still-current facts were silently dropped — the failure mode these weekly refreshes are most prone to.
Suggestions
CLAUDE.md:75-76— this note is prose policy living inside thebashfence as shell comments, whereas the comparable Helm note got its own###section. Consider lifting it just below the fence so it reads as documentation rather than as a command annotation. Cosmetic; not worth a re-push on its own.
Strengths
- Both added claims are specific and checkable (exact probe paths, exact env-var names) instead of vague prose, which is what made verification cheap and is the reason this refresh could be confirmed rather than assumed.
- Purely additive diff, so the refresh carries no silent-deletion risk.
Recommended Action
- No Critical or Important issues — good to merge.
- Fold the Suggestion in opportunistically on a future refresh.
Added
Pruned
Fixed
Uncertain
staff-engineer/docs-claude-weekly-refresh-20260706because pushing the requesteddocs/claude-weekly-refresh-20260706name was rejected by GitHub due to a remote directory/file namespace conflict.Verification
git diff --check.