probe(ci): BLO-20869 — post-fix v2, force verify_serialized_server skipped, do not merge - #1009
Closed
allyblockcast[bot] wants to merge 2 commits into
Closed
probe(ci): BLO-20869 — post-fix v2, force verify_serialized_server skipped, do not merge#1009allyblockcast[bot] wants to merge 2 commits into
allyblockcast[bot] wants to merge 2 commits into
Conversation
…r (BLO-20869) Fold verify_serialized_server's result into the existing if:always() verify aggregator's lane_results check, alongside the other required lanes. A cancelled, skipped, or never-scheduled serialized shard now fails the one required check instead of being invisible to the merge gate (mergeStateStatus reads BLOCKED instead of UNSTABLE/MERGEABLE). Rebased onto current master: BLO-20867/#964 rewrote this job into a bash lane_results map after the original fix branch was opened; this carries the same change forward in that shape rather than reverting #964's cancelled-vs-failed distinction. Co-Authored-By: Paperclip <noreply@paperclip.ing>
…ipped, do not merge On top of the rebased fix (fix/blo-20869-require-serialized-server-v2): a skipped serialized shard should now fail the required verify check and the PR should read BLOCKED. Throwaway -- closing without merging once the reading is captured. Co-Authored-By: Paperclip <noreply@paperclip.ing>
Author
|
🔗 Paperclip issue: BLO-20869 |
1 similar comment
Author
|
🔗 Paperclip issue: BLO-20869 |
13 tasks
Author
|
Hey @allyblockcast[bot]! Before this PR can be reviewed, a few things need attention: Missing or incomplete:
Once updated, push a new commit and these checks will re-run automatically. — commitperclip |
Author
Ally — Consolidated PR ReviewLenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex. Looks good for its stated throwaway-probe purpose. The forced skip reaches the real required-check aggregator, and the exact-head Suggestions (1)
Strengths
Recommended Action
|
|
Closing the throwaway BLO-20869 post-fix probe per the PR body. Evidence was captured by the settled blocked check state; the real fix remains #1007. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge — throwaway probe, closing without merging once evidence is captured.
Rebased version of #958, stacked on the rebased fix (#1007) instead of the stale original. Same probe:
verify_serialized_serverforced toskippedviaif: false, on top of the fix that folds its result into theverifyaggregator.Expected reading once checks settle:
verifyfails (the skipped lane is now asserted), somergeStateStatus: BLOCKED— confirming the fix closes the gap.Tracking: https://paperclip.blockcast.net/BLO/issues/BLO-20869
Fix under test: #1007