Skip to content

test(server): remove exact-duplicate workspace-runtime provisioning test (BLO-21118) - #1044

Queued
allyblockcast[bot] wants to merge 1 commit into
masterfrom
sre/blo-21118-dedupe-workspace-runtime-test
Queued

test(server): remove exact-duplicate workspace-runtime provisioning test (BLO-21118)#1044
allyblockcast[bot] wants to merge 1 commit into
masterfrom
sre/blo-21118-dedupe-workspace-runtime-test

Conversation

@allyblockcast

@allyblockcast allyblockcast Bot commented Aug 5, 2026

Copy link
Copy Markdown

Thinking Path

  • Paperclip is the open source app people use to manage AI agents for work.
  • The CI suite is the safety net for every PR entering the merge queue.
  • server/src/__tests__/workspace-runtime.test.ts had one provisioning-heavy test duplicated byte-for-byte.
  • The duplicate copy used a shorter timeout than neighboring provisioning tests, so unrelated PRs could fail under runner contention.
  • This pull request removes the duplicate and keeps the surviving test at the timeout used by equivalent provisioning tests.
  • The benefit is the same coverage with less flake pressure on unrelated PRs.

Linked Issues or Issue Description

Paperclip issue BLO-21118 tracks CI server-shard flakes caused by the duplicate workspace-runtime provisioning test. The observed failure was on PR #956, run 30954922141, in General tests (server 3/4).

What Changed

  • Removed the byte-identical duplicate provisions worktree-local pnpm node_modules instead of reusing base-repo links test from server/src/__tests__/workspace-runtime.test.ts.
  • Kept the surviving test and raised its timeout from 30_000 to 120_000, matching nearby real git worktree plus pnpm install provisioning tests.

Verification

CI is the verifying signal: the workspace-runtime test no longer appears twice, and the surviving provisioning-heavy test has the same timeout budget as sibling tests that do equivalent work.

Risks

Low risk. This removes duplicate coverage rather than removing a unique assertion. The timeout change affects only the surviving heavy provisioning test and aligns it with existing neighboring tests.

Model Used

Claude Sonnet 5 (claude-sonnet-5[1m]), agentic coding session with repository inspection and CI log analysis.

Checklist

  • I have included a thinking path that traces from project context to this change
  • I have specified the model used (with version and capability details)
  • I have searched GitHub for duplicate or related PRs and linked them above
  • I have either linked an existing issue or described the issue in-PR
  • I have considered and documented risks above

@allyblockcast

allyblockcast Bot commented Aug 5, 2026

Copy link
Copy Markdown
Author

🔗 Paperclip issue: BLO-21118
🔗 Paperclip issue: BLO-21953

1 similar comment
@allyblockcast

allyblockcast Bot commented Aug 5, 2026

Copy link
Copy Markdown
Author

🔗 Paperclip issue: BLO-21118
🔗 Paperclip issue: BLO-21953

@allyblockcast

allyblockcast Bot commented Aug 5, 2026

Copy link
Copy Markdown
Author

Hey @allyblockcast[bot]! Before this PR can be reviewed, a few things need attention:

Missing or incomplete:

  • Missing section: ## Thinking Path
  • Missing section: ## What Changed
  • Missing section: ## Verification
  • Missing section: ## Risks
  • Missing section: ## Model Used

Once updated, push a new commit and these checks will re-run automatically.

— commitperclip

@kkroo kkroo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: removes a byte-identical duplicate provisioning test and aligns the surviving heavy test timeout with neighboring provisioning tests, preserving coverage while reducing CI flake pressure.

@kkroo
kkroo enabled auto-merge August 5, 2026 11:01
@allyblockcast

allyblockcast Bot commented Aug 5, 2026

Copy link
Copy Markdown
Author

Ally — Consolidated PR Review

Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: 9aacbfb

Looks good. No Critical or Important issues found.

Strengths

  • The removed test duplicated the surviving provisioning setup and all four assertions, so behavioral coverage remains intact.
  • The surviving 120_000 timeout matches neighboring provisioning-heavy integration tests and avoids contention-driven flakes without weakening an explicit performance contract.
  • The relevant General tests (server 3/4) check passed on this head.

Recommended Action

The analysis is clean, but this PR is authored by app/allyblockcast. The exact head must be reopened under an independent author before the Ally App can provide the gate-authorizing approval.

…est (BLO-21118)

"provisions worktree-local pnpm node_modules instead of reusing
base-repo links" existed twice with byte-identical bodies (same
blame timestamp, evidently a copy/paste artifact) but different
timeouts — 30s and 15s. Both do a real pnpm install + git worktree
provision, which the file's other heavy-provisioning tests budget
120s for. Under CI runner contention the 15s copy timed out and
failed unrelated PRs' shards (observed on PR #956, 2026-08-04).

Delete the redundant copy and align the survivor's timeout with its
siblings instead of just papering over the flake with a bigger
number on a test that shouldn't exist twice.
@kkroo
kkroo force-pushed the sre/blo-21118-dedupe-workspace-runtime-test branch from 9aacbfb to 5d40c9f Compare August 5, 2026 18:12
@allyblockcast

allyblockcast Bot commented Aug 5, 2026

Copy link
Copy Markdown
Author

Ally — Consolidated PR Review

Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: 5d40c9f

Looks good. No Critical or Important issues found.

Strengths

  • The removed test duplicated the surviving fixture setup, workspace realization, and all four assertions, so behavioral coverage remains intact.
  • Raising the surviving test timeout to 120_000 matches the provisioning-heavy neighboring tests and removes the duplicate's inconsistent 15_000 budget.
  • The patch is isolated to test code and does not alter production, SQL, side-effect, type, error-handling, or trust-boundary behavior.

Recommended Action

The analysis is clean, but this PR is authored by app/allyblockcast. The exact head must be reopened under an independent author before the Ally App can provide the gate-authorizing approval.

@kkroo
kkroo added this pull request to the merge queue Aug 5, 2026
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant