test(server): remove exact-duplicate workspace-runtime provisioning test (BLO-21118) - #1044
test(server): remove exact-duplicate workspace-runtime provisioning test (BLO-21118)#1044allyblockcast[bot] wants to merge 1 commit into
Conversation
1 similar comment
|
Hey @allyblockcast[bot]! Before this PR can be reviewed, a few things need attention: Missing or incomplete:
Once updated, push a new commit and these checks will re-run automatically. — commitperclip |
kkroo
left a comment
There was a problem hiding this comment.
Approved: removes a byte-identical duplicate provisioning test and aligns the surviving heavy test timeout with neighboring provisioning tests, preserving coverage while reducing CI flake pressure.
Ally — Consolidated PR ReviewLenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex. Looks good. No Critical or Important issues found. Strengths
Recommended ActionThe analysis is clean, but this PR is authored by |
…est (BLO-21118) "provisions worktree-local pnpm node_modules instead of reusing base-repo links" existed twice with byte-identical bodies (same blame timestamp, evidently a copy/paste artifact) but different timeouts — 30s and 15s. Both do a real pnpm install + git worktree provision, which the file's other heavy-provisioning tests budget 120s for. Under CI runner contention the 15s copy timed out and failed unrelated PRs' shards (observed on PR #956, 2026-08-04). Delete the redundant copy and align the survivor's timeout with its siblings instead of just papering over the flake with a bigger number on a test that shouldn't exist twice.
9aacbfb to
5d40c9f
Compare
Ally — Consolidated PR ReviewLenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex. Looks good. No Critical or Important issues found. Strengths
Recommended ActionThe analysis is clean, but this PR is authored by |
Thinking Path
Linked Issues or Issue Description
Paperclip issue BLO-21118 tracks CI server-shard flakes caused by the duplicate workspace-runtime provisioning test. The observed failure was on PR #956, run 30954922141, in
General tests (server 3/4).What Changed
provisions worktree-local pnpm node_modules instead of reusing base-repo linkstest fromserver/src/__tests__/workspace-runtime.test.ts.30_000to120_000, matching nearby realgit worktreepluspnpm installprovisioning tests.Verification
CI is the verifying signal: the workspace-runtime test no longer appears twice, and the surviving provisioning-heavy test has the same timeout budget as sibling tests that do equivalent work.
Risks
Low risk. This removes duplicate coverage rather than removing a unique assertion. The timeout change affects only the surviving heavy provisioning test and aligns it with existing neighboring tests.
Model Used
Claude Sonnet 5 (
claude-sonnet-5[1m]), agentic coding session with repository inspection and CI log analysis.Checklist