[codex] stabilize plugin store DB startup timeout

[kkroo]

Thinking Path

General tests (server 4/4) on PR #850 failed before the plugin-store consistency assertions ran because startEmbeddedPostgresTestDatabase exceeded the suite's local 20_000 beforeAll timeout. The server Vitest config already documents loaded ARC embedded-Postgres startup reaching roughly 40 seconds and sets the project hook timeout to 120_000. This PR removes that accidental narrow override for the plugin-store embedded-DB setup while keeping the test body timeouts unchanged.

Linked Issues or Issue Description

No dedicated Paperclip issue yet. This is a CI stabilization follow-up from the failing plugin-store-consistency.test.ts job observed while unblocking the Paperclip PR queue.

What Changed

• Raised the torn plugin store — activation fails closed embedded-Postgres beforeAll timeout from 20_000 to 120_000.
• Left the individual behavior/assertion test timeouts intact.

Verification

• pnpm install --frozen-lockfile completed, with the known plugin SDK bin-link warnings.
• pnpm exec vitest run --project @paperclipai/server server/src/__tests__/plugin-store-consistency.test.ts passed (10 passed, 2 skipped).
• git diff --check passed.

Risks

Low. This only gives the setup hook the same headroom already used by the server test project and other embedded-Postgres suites. A truly broken database startup will still fail; it just will not fail at the obsolete 20 second local cap.

Model Used

• Provider: OpenAI
• Model: GPT-5 Codex
• Mode: agentic software engineering

Checklist

• I have included a thinking path that traces from project context to this change
• I have specified the model used (with version and capability details)
• I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work
• I have searched GitHub for duplicate or related PRs and linked them above
• I have either (a) linked existing issues with Fixes: # / Closes # / Refs # OR (b) described the issue in-PR following the relevant issue template
• I have run focused tests locally and they pass
• I have added or updated tests where applicable
• If this change affects the UI, I have included before/after screenshots
• I have updated relevant documentation to reflect my changes
• I have considered and documented any risks above
• All Paperclip CI gates are green
• Ally review is clean

[cursor]

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

[kkroo]

/test
/ally review

[allyblockcast]

Hey @kkroo! Before this PR can be reviewed, a few things need attention:

Missing or incomplete:

• Add the dedup-search checkbox to your PR description and check it once you have searched the GitHub PR list for similar PRs. See the PR template at .github/PULL_REQUEST_TEMPLATE.md and CONTRIBUTING.md → "Before You Start: Search First".

Once updated, push a new commit and these checks will re-run automatically.

— commitperclip

[allyblockcast]

Ally — Consolidated PR Review

Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: f70661b

Looks good. No Critical or Important issues found.

Strengths

• The suite-specific setup timeout now matches the server project's documented hookTimeout: 120_000, removing the accidental 20-second override without weakening the individual behavioral assertions.
• The change is narrowly scoped to test infrastructure and does not affect production runtime behavior.

Recommended Action

Approve and merge once required CI checks are green.

[allyblockcast]

Ally — Consolidated PR Review

Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: f70661b

Looks good. No Critical or Important issues found.

Strengths

• The suite-specific setup timeout now matches the server project's documented hookTimeout: 120_000, removing the accidental 20-second override without weakening the individual behavioral assertions.
• The change is narrowly scoped to test infrastructure and does not affect production runtime behavior.

Recommended Action

Approve and merge once required CI checks are green.

Duplicate Ally approval for the same head; keeping review 4836929908 as the operative attestation.

[allyblockcast]

Ally — Consolidated PR Review

Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: 38c2d08

Looks good. No Critical or Important issues found.

Strengths

• The suite-specific setup timeout at server/src/__tests__/plugin-store-consistency.test.ts:253 now matches the server project’s established 120-second hook budget for contended embedded-Postgres startup.
• Individual behavioral test timeouts remain unchanged, so the added setup headroom does not weaken detection of activation hangs.
• The change is isolated to test infrastructure and does not affect production SQL, runtime behavior, trust boundaries, or type design.

Recommended Action

Approve and merge once required CI checks are green.

[allyblockcast]

Ally — Consolidated PR Review

Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: 38c2d08

Looks good. No Critical or Important issues found.

Strengths

• The suite-specific setup timeout at server/src/__tests__/plugin-store-consistency.test.ts:253 now matches the server project’s established 120-second hook budget for contended embedded-Postgres startup.
• Individual behavioral test timeouts remain unchanged, so the added setup headroom does not weaken detection of activation hangs.
• The change is isolated to test infrastructure and does not affect production SQL, runtime behavior, trust boundaries, or type design.

Recommended Action

Approve and merge once required CI checks are green.

Dismiss duplicate Ally bot approval; keeping operative Ally user approval 4838391530 for head 38c2d08.

Dismiss stale Ally approval after branch update: body attests 38c2d08 but current head is 74ebffb; needs a fresh exact-head review.

[allyblockcast]

Ally — Consolidated PR Review

Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: 74ebffb

Looks good. No Critical or Important issues found.

Strengths

• The setup hook at server/src/__tests__/plugin-store-consistency.test.ts:253 now has the same 120-second budget as the server test project's embedded-Postgres startup allowance.
• Individual behavioral test timeouts remain unchanged, so this does not hide activation hangs or weaken the fail-closed assertions.
• The change is isolated to test infrastructure and introduces no production SQL, runtime, trust-boundary, error-handling, or type-design risk.

Recommended Action

Approve and merge once required CI checks are green.

[allyblockcast]

Ally — Consolidated PR Review

Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: 74ebffb

Looks good. No Critical or Important issues found.

Strengths

• The setup hook at server/src/__tests__/plugin-store-consistency.test.ts:253 now has the same 120-second budget as the server test project's embedded-Postgres startup allowance.
• Individual behavioral test timeouts remain unchanged, so this does not hide activation hangs or weaken the fail-closed assertions.
• The change is isolated to test infrastructure and introduces no production SQL, runtime, trust-boundary, error-handling, or type-design risk.

Recommended Action

Approve and merge once required CI checks are green.

Dismiss duplicate Ally bot approval; keeping operative Ally user approval 4839575603 for head 74ebffb.

Dismiss stale Ally approval after branch update: body attests 74ebffb but current head is 9d20758; needs a fresh exact-head review.

[kkroo]

@allyblockcast please review current head 9d20758. Prior approvals were dismissed because branch updates changed the head.

[kkroo]

/ally review

Current head: 9d20758. Previous approvals were dismissed as stale after branch updates.

[allyblockcast]

Ally — Consolidated PR Review

Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: 9d20758

Looks good. No Critical or Important issues found.

Strengths

• The setup hook at server/src/__tests__/plugin-store-consistency.test.ts:253 now matches the server test project's established 120-second embedded-Postgres hook budget.
• Individual behavioral test timeouts remain unchanged, so the added startup headroom does not hide activation hangs or weaken the fail-closed assertions.
• The change is isolated to test infrastructure, and the affected server CI shard passes on this head.

Recommended Action

Approve and merge once the remaining required CI check is green.

[allyblockcast]

Ally — Consolidated PR Review

Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: 9d20758

Looks good. No Critical or Important issues found.

Strengths

• The setup hook at server/src/__tests__/plugin-store-consistency.test.ts:253 now matches the server test project's established 120-second embedded-Postgres hook budget.
• Individual behavioral test timeouts remain unchanged, so the added startup headroom does not hide activation hangs or weaken the fail-closed assertions.
• The change is isolated to test infrastructure, and the affected server CI shard passes on this head.

Recommended Action

Approve and merge once the remaining required CI check is green.

Dismiss duplicate Ally bot approval; keeping operative Ally user approval 4839748706 for head 9d20758.