fix(header): remove fixed height from logo to preserve aspect ratio#478
Merged
gabitoesmiapodo merged 1 commit intodevelopfrom Apr 21, 2026
Merged
fix(header): remove fixed height from logo to preserve aspect ratio#478gabitoesmiapodo merged 1 commit intodevelopfrom
gabitoesmiapodo merged 1 commit intodevelopfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses header logo stretching by removing the fixed height prop from the Logo component so the rendered height is derived from the image’s intrinsic dimensions while width remains controlled.
Changes:
- Removed the fixed
height={77}from the headerLogoimage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #476
Both
widthandheightwere fixed on the logo element, which forcesa specific aspect ratio regardless of the image's natural dimensions.
Removing the fixed height lets the browser derive it from the SVG's
intrinsic size, so the logo always renders proportionally.
Changes
height={77}fromchakra.imginLogo.tsx; height is nowderived from the image's intrinsic dimensions while
width={193}continues to control the render size
Acceptance criteria
Test plan
Automated tests
No automated tests added or modified — this is a single-prop removal
with no logic change.
Run:
pnpm testManual verification
Breaking changes
None.
Checklist
Screenshots
None.