fix(token-select): remove trailing divider from last network item#479
Merged
gabitoesmiapodo merged 2 commits intodevelopfrom Apr 21, 2026
Merged
fix(token-select): remove trailing divider from last network item#479gabitoesmiapodo merged 2 commits intodevelopfrom
gabitoesmiapodo merged 2 commits intodevelopfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the trailing divider after the final item in the network selection dropdown by adjusting the shared MenuItem styling in the UI Menu wrapper.
Changes:
- Add Chakra
_lastpseudo-prop styling to suppress the bottom border on the finalMenuItem.
Comments suppressed due to low confidence (1)
src/components/sharedComponents/ui/Menu/index.tsx:46
_lastonly removes the divider in the default state, but the_hoverand_activestyles re-applyborderBottom. This means the last item will still show a trailing divider when hovered/pressed. Consider overridingborderBottom(orborder) inside_last._hoverand_last._active, or stop settingborderBottomin_hover/_activeso the last item stays borderless in all states.
borderBottom="1px solid var(--item-border-color)"
_last={{ borderBottom: 'none' }}
color="var(--item-color)"
columnGap={2}
cursor="pointer"
fontSize="16px"
fontWeight="400"
justifyContent="flex-start"
lineHeight="1.4"
minHeight="48px"
overflow="hidden"
paddingX={4}
transition="background-color {durations.fast} ease-in-out"
_hover={{
backgroundColor: 'var(--item-background-color-hover)',
color: 'var(--item-color-hover)',
borderBottom: '1px solid var( --item-border-color-hover)',
}}
_active={{
backgroundColor: 'var(--item-background-color-active)',
color: 'var(--item-color-active)',
borderBottom: '1px solid var( --item-border-color-active)',
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #477
MenuItemappliedborderBottomunconditionally to every item in adropdown, including the last one. Adding the
_lastpseudo-propremoves the trailing separator without affecting any other items.
Changes
_last={{ borderBottom: 'none' }}toMenuIteminMenu/index.tsxto suppress the bottom border on the final itemin any menu list
Acceptance criteria
network selection dropdown
Test plan
Automated tests
No automated tests added or modified — this is a single-prop addition
with no logic change.
Run:
pnpm testManual verification
Breaking changes
None.
Checklist
Screenshots
None.