fix: post transcript quote-reply before in-process fan-out - #33
Merged
Conversation
After the one-phone collapse, translation could land in the group before the transcript quote-reply. Await that send, then spawn fan-out so in-chat and Language Threads follow the original speaker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Voice notes could show a translation or Language Threads relay in the group before
📝 Transcript:. After the one-phone collapse, fan-out no longer waits for Signal to deliver the bot's own transcript, and it was spawned before that quote-reply was sent.The transcript quote-reply is now sent first; in-chat auto-translate and sidecar relays follow for the original speaker (quote author on
!transcribe). A failed send does not fan out. Bot translation replies are still not re-translated.Fixes #30
Test plan
📝 Transcript:appears in the source chat before any in-chat translation or sidecar relay for the same utterance!transcribe: same ordering; fan-out attributed to the quoted voice author, not the command senderLocal
npm run cipassed (fmt, Clippy, 93.08% line coverage). Unit tests record/v2/sendthen the fan-out hook and assert["send", "fanout"].