test: cover speaker-aware transcript fan-out - #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewers can now prove one STT success fans spoken text into both in-chat translate and Language Threads with the original speaker as source. Before this, the suite path was untested and handler fan-out only covered empty-spoken early returns.
!transcribestill attributes speech to the typer when the quote has noauthor_number— that gap is characterized, not fixed. The suite test uses separate in-memory stores because in-chat and Language Threads are exclusive per store; the suite still always invokes both handlers.Fixes #31.
Test plan
npm run cilocally (fmt, clippy-D warnings, llvm-cov 93.41% lines, commitlint)test.yml+commitlint.ymlgreen on this PR