Use time-based units instead of frame-based for default parameters#532
Open
Breakthrough wants to merge 1 commit intomainfrom
Open
Use time-based units instead of frame-based for default parameters#532Breakthrough wants to merge 1 commit intomainfrom
Breakthrough wants to merge 1 commit intomainfrom
Conversation
Owner
Author
|
Will revisit this once PR #540 lands. In the meantime, PR #540 just uses the nominal framerate as reported by the container to lazily calculate frame margin in terms of seconds at runtime. When that lands, we might be able to avoid introducing a new property called margin/temporal margin and just allow passing timecodes for frame-margin. |
Breakthrough
force-pushed
the
issue-531-temporal-margin
branch
from
d05f44a to
fb7590f
Compare
Breakthrough
force-pushed
the
issue-531-temporal-margin
branch
from
fb7590f to
78fc139
Compare
Breakthrough
changed the title
Breakthrough
force-pushed
the
issue-531-temporal-margin
branch
from
78fc139 to
f788f77
Compare
Breakthrough
force-pushed
the
issue-531-temporal-margin
branch
from
f788f77 to
6d3f253
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new temporal margin property to replace frame margin as per #531. The latter does not work well for VFR video, so we need to allow passing in time values for the margin used when extracting images in each scene.