Add the Good Deal Test scorecard page - #68
Conversation
A 100-point rubric at /good-deal-test for judging the Canada-US tariff package against Build Canada's standard: more sovereign, more united, more prosperous than the status quo. Ported from the working document onto the site's design system rather than its standalone CSS -- Soehne/Financier/Founders Grotesk via the type-* utilities, brand tokens for surfaces and text, and the pine / copper / auburn ramps for the win / pass / fail vocabulary. Content is held in data arrays so criteria stay editable in one place. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Greptile SummaryAdds a statically rendered Good Deal Test scorecard for evaluating a Canada–US tariff package.
Confidence Score: 4/5The PR appears safe to merge, with a non-blocking mobile readability issue in the criterion-band rows. The page is a self-contained static server component using valid existing design-system utilities, but its always-two-column rubric rows leave very little width for descriptions on narrow screens. Files Needing Attention: src/app/good-deal-test/page.tsx
|
| Filename | Overview |
|---|---|
| src/app/good-deal-test/page.tsx | Adds the complete scorecard route using established design tokens; the criterion-band layout becomes overly narrow on small mobile viewports. |
Prompt To Fix All With AI
### Issue 1
src/app/good-deal-test/page.tsx:568
**Narrow mobile band descriptions**
The band rows retain a max-content two-column layout on narrow screens after the surrounding margins and padding are applied, forcing descriptions into an excessively narrow column and making the scorecard difficult to scan.
```suggestion
className="grid grid-cols-1 items-start gap-2 sm:grid-cols-[max-content_minmax(0,1fr)] sm:gap-3"
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "Add the Good Deal Test scorecard page" | Re-trigger Greptile
| {c.bands.map((b) => ( | ||
| <div | ||
| key={b.label} | ||
| className="grid grid-cols-[max-content_minmax(0,1fr)] items-start gap-3" |
There was a problem hiding this comment.
Narrow mobile band descriptions
The band rows retain a max-content two-column layout on narrow screens after the surrounding margins and padding are applied, forcing descriptions into an excessively narrow column and making the scorecard difficult to scan.
| className="grid grid-cols-[max-content_minmax(0,1fr)] items-start gap-3" | |
| className="grid grid-cols-1 items-start gap-2 sm:grid-cols-[max-content_minmax(0,1fr)] sm:gap-3" |
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/app/good-deal-test/page.tsx
Line: 568
Comment:
**Narrow mobile band descriptions**
The band rows retain a max-content two-column layout on narrow screens after the surrounding margins and padding are applied, forcing descriptions into an excessively narrow column and making the scorecard difficult to scan.
```suggestion
className="grid grid-cols-1 items-start gap-2 sm:grid-cols-[max-content_minmax(0,1fr)] sm:gap-3"
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Adds
/good-deal-test— a 100-point rubric for judging the Canada–US tariff package against Build Canada's standard: more sovereign, more united, more prosperous than the status quo.What's on the page
Implementation notes
Ported from the working document onto the site's design system rather than carrying over its standalone CSS:
type-*utilities, not Google Fontsbg-bg-alt,border-border-light,text-accent, …)ThemeShellhas no dark variantpillars,scoreBands,checklist, …) so criteria are editable in one placeServer component, no client JS.
Verification
eslint,tsc --noEmit, andpnpm lintare clean (the 4 remaining warnings are pre-existing, in files this PR doesn't touch). The page renders with all sections present via the dev server.Not visually verified — the browser extension wasn't connected in my session, so the layout hasn't been eyeballed. Worth a look at the preview deploy, particularly the criterion card headers (heading and points chip are baseline-aligned) and the
max-contentband-label column at mobile widths.🤖 Generated with Claude Code