perf(vm): allocate up to 16 script arguments and 64 local variables o… - #372
Open
cobaltgit wants to merge 2 commits into
Open
perf(vm): allocate up to 16 script arguments and 64 local variables o…#372cobaltgit wants to merge 2 commits into
cobaltgit wants to merge 2 commits into
Conversation
…n the stack before falling back to heap takes cues from Purplesmaug's stack allocation of function args. Very early builds did this but hard-capped the local variables per code entry to 128 without any heap allocation fallback after that threshold, hamstringing compatibility.
Collaborator
Author
|
Was originally done to improve performance on the PS2 target, should apply on similarly low-end targets where the interpreter bottlenecks. |
cobaltgit
marked this pull request as ready for review
July 31, 2026 10:19
Collaborator
Author
|
Seems to go best with WAD 15/16 games as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n the stack before falling back to heap
takes cues from Purplesmaug's stack allocation of function args. Very early builds did this but hard-capped the local variables per code entry to 128 without any heap allocation fallback after that threshold, hamstringing compatibility.
Should help in cases where malloc slogs