INS-1699 - #170
Merged
Merged
Conversation
RuoxiZhang08
approved these changes
Jul 30, 2026
There was a problem hiding this comment.
🟡 Not ready to approve
The new resolver can currently throw an unhelpful NullPointerException if num_resources is absent/null, and should handle that case explicitly.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Adds a new homepage stat to the private ES GraphQL API by exposing a numberOfResources query field and wiring it to an OpenSearch-backed resolver in PrivateESDataFetcher.
Changes:
- Added
numberOfResources: Intto the private ES GraphQLQueryType. - Wired a new
numberOfResourcesdata fetcher inPrivateESDataFetcher. - Implemented
numberOfResources()to readnum_resourcesfrom thehome_statsOpenSearch document.
File summaries
| File | Description |
|---|---|
| src/main/resources/graphql/ins-private-es.graphql | Exposes numberOfResources on the private ES GraphQL QueryType. |
| src/main/java/gov/nih/nci/bento_ri/model/PrivateESDataFetcher.java | Adds a resolver + runtime wiring to fetch num_resources from the home stats OpenSearch endpoint. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Low
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Added resource counts for homepage stats.
Change Details (Specifics)
Added GraphQL field for returning resource counts, with an accompanying controller function.
Related Ticket(s)
https://tracker.nci.nih.gov/browse/INS-1699