Skip to content

Fix four input parser defects found during User Guide key inventory #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohalinasre wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix four input parser defects found during User Guide key inventory #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1058a7
Fix stationary_parts read path for mesh_deformation in zoneIO.cpp
mohalinasre Jul 23, 2026
ced2ed0
Validate search_method at parse time in interfaceIO.cpp
mohalinasre Jul 23, 2026
6af4763
Correct error message for missing convergence_criteria block
mohalinasre Jul 23, 2026
4872877
Correct boundaries block hint in zoneIO.cpp
mohalinasre Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/controls/controlsIO.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ void controls::read(YAML::Node inputNode)
}
else
{
errorMsg("convergence_controls block is not provided in the "
errorMsg("convergence_criteria block is not provided in the "
"yaml input file");
}

Expand Down
6 changes: 6 additions & 0 deletions src/mesh/interface/interfaceIO.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,12 @@ void interface::read(const YAML::Node& inputNode)
{
searchMethodName =
inputNode["search_method"].template as<std::string>();
if (searchMethodName != "stk_kdtree")
{
errorMsg("invalid search_method '" + searchMethodName +
"' provided for interface; only stk_kdtree "
"is supported");
}
}

if (inputNode["search_tolerance"])
Expand Down
9 changes: 5 additions & 4 deletions src/mesh/zone/zoneIO.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,9 @@ void zone::read(const YAML::Node& domain)
domain["domain_models"]["mesh_deformation"]["stationary_parts"])
{
std::vector<std::string> stationaryPartNames =
domain["domain_models"]["domain_motion"]["stationary_parts"]
.template as<std::vector<std::string>>();
domain["domain_models"]["mesh_deformation"]
["stationary_parts"]
.template as<std::vector<std::string>>();

for (auto stationaryPartName : stationaryPartNames)
{
Expand Down Expand Up @@ -242,8 +243,8 @@ void zone::read(const YAML::Node& domain)
{
errorMsg("zone: `boundaries` block is missing for domain `" +
domain["name"].template as<std::string>() +
"`.\nboundary_conditions:\n -name: <boundary name>\n type: "
"<boundary type>\n location: <location list>");
"`.\nboundaries:\n- name: <boundary name>\n type: "
"<boundary type>\n location: <location list>");
}
}

Expand Down