This repository was archived by the owner on May 20, 2025. It is now read-only.
[do not merge] trying out sass with gov uk elements - #75
Open
vygis wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent a day looking into switching Bootstrap Lass to use Sass, and include at least some of the styles from Gov UK elements directly (Gov UK uses Sass).
I've come to the following conclusions:
&:extend(.class all)less statements cannot be mapped directly.govuk_templatenpm package in their compiled form, together with a server side template, so it would not make sense to even attempt to integrate them. Some of the other styles that are provided bygovuk_elementswould be more realistic to integrate, but it would need a complex set of includables and variable overriding, especially when combining with Bootstrap. Even then,govuk_elementsdo not provide everything we need, so they would need to be extended, which begs the question of including them in the first place.I would therefore recommend not to go down this path and continue using Bootstrap, unless there is a pressing need to use Gov Uk styles.
Having said that, a lot of the existing Bootstrap customisation in
ngGovUkcould be improved and made to fit Boostrap better. I would suggest focusing on that.