Skip to content

Structures properties - #22

Open
nicholasfrancia wants to merge 14 commits into
mainfrom
structures_properties
Open

Structures properties#22
nicholasfrancia wants to merge 14 commits into
mainfrom
structures_properties

Conversation

@nicholasfrancia

Copy link
Copy Markdown
Collaborator

Multiple data fields have been added to describe the output crystal properties. These can be classified into:

  • Energy data fields related to variable composition calculations.
  • Per-atom properties (forces, partial charges)
  • Band structure, density of states and related properties
  • Phonons
  • Magnetic, mechanical, and transport properties

Corrections to .dic files and examples were also made, as highlighted in other PR/Issues.

@vaitkus

vaitkus commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

@nicholasfrancia Some of the error messages related to measurement units are due to typos (e.g. "bohr_magneton" should be "Bohr_magnetons") while in other cases the units simply have not previously been encountered. Note, that unit "per centimetre" is most likely the same as "reciprocal_centimetres".

Once such duplicates are resolved, I can add the missing units to a provisional branch that is currently used for validation of CSP dictionaries (COMCIFS/Enumeration_Templates#14).

@nicholasfrancia

Copy link
Copy Markdown
Collaborator Author

Thanks, that would be great! Apart from Bohr_magnetons, I've also changed the "per_centimetre" into "reciprocal_centimetres" and "per_kelvin" into "reciprocal_kelvins"

@vaitkus

vaitkus commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

I just pushed the update to the unit enumeration list. If you rerun GitHub actions, the error messages should no longer appear.

As I am not very familiar with the field, the unit descriptions involved some guesswork (see PR COMCIFS/Enumeration_Templates#14) . It would be great if someone from you team could eventually review them.

Comment thread cif_compchem.dic Outdated
Comment thread cif_compchem.dic Outdated
Comment thread cif_compchem.dic
Comment thread cif_compchem.dic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants