Carry across selected updates from development branch - #640
Merged
Conversation
Added _space_group.reference_setting, _space_group.transform_Pp_abc and _space_group.transform_Qq_xyz --------- Co-authored-by: Antanas Vaitkus <antanas.vaitkus90@gmail.com> (cherry picked from commit f559391)
The atom type symbol contains a charge, not an oxidation state. (cherry picked from commit 7e71113)
(cherry picked from commit 2efc4f9)
_exptl_crystal.id as a key data name of a Set category is defined in the multiblock dictionary. (cherry picked from commit d2cf28c)
(cherry picked from commit 9b5d500)
(cherry picked from commit ee4e0f2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The missing symCIF data names should be present in the next release.
_diffrn.crystal_idand_expt_crystal.idare defined in the multi-block dictionary.No need for review as these changes have passed review in the main branch already.