Relax dimension requirements for some data items - #74
Merged
Conversation
Data items _atom_site_fourier_wave_vector.q_coeff_seq_id and _atom_site_fourier_wave_vector.q_coeff may have several values in the same data block that are lists of differing lengths as showcased by the category usage examples in the dictionary. Therefore, these items should be marked as having an unknown number of elements instead of requiring them to have the same number of elements as the modulation dimension.
vaitkus
force-pushed
the
relaxed-dimension-requirements
branch
from
July 28, 2026 10:12
9bdf05a to
aae843e
Compare
jamesrhester
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #72.
Data items _atom_site_fourier_wave_vector.q_coeff_seq_id and _atom_site_fourier_wave_vector.q_coeff may have several values in the same data block that are lists of differing lengths as showcased by the category usage examples in the dictionary. Therefore, these items should be marked as having an unknown number of elements instead of requiring them to have the same number of elements as the modulation dimension.
Note, that there are several other data items that derive their dimension base on the
_cell.modulation_dimensiondata item value (e.g._diffrn_reflns.limit_index_m_max_list), however, I am not sure if these should also be relaxed.