Skip to content

fix: move Homebrew formula to repository root for tap discovery#883

Open
alexmohr wants to merge 1 commit into
COVESA:masterfrom
alexmohr:fix/homebrew
Open

fix: move Homebrew formula to repository root for tap discovery#883
alexmohr wants to merge 1 commit into
COVESA:masterfrom
alexmohr:fix/homebrew

Conversation

@alexmohr

Copy link
Copy Markdown
Contributor

The formula introduced in #881 was placed at homebrew/Formula/dlt-daemon.rb, but brew tap with an explicit URL clones the repository and searches for formulas only in a Formula/ directory at the repository root. The subdirectory location is silently ignored, causing the tap to succeed but brew install to fail with "No available formula".
Additionally, the original brew tap COVESA/dlt-daemon (without a URL) expects a separate repository named COVESA/homebrew-dlt-daemon, which does not exist.
Fix

  • Move homebrew/Formula/dlt-daemon.rb -> Formula/dlt-daemon.rb (root-level, where Homebrew looks)
  • Update install instructions to use the explicit-URL tap form, which works directly from this repository without a separate tap repo:
    brew tap COVESA/dlt-daemon https://github.com/COVESA/dlt-daemon
    brew install COVESA/dlt-daemon/dlt-daemon

Alexander Mohr alexander.m.mohr@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH
Provider Information

Signed-off-by: Alexander Mohr <alexander.m.mohr@mercedes-benz.com>
@minminlittleshrimp

Copy link
Copy Markdown
Collaborator

Hi @alexmohr
Is the build log valid and can be captured from your side?

@alexmohr

Copy link
Copy Markdown
Contributor Author

Hi @alexmohr Is the build log valid and can be captured from your side?

The output from the current master version is

brew tap COVESA/dlt-daemon
brew install dlt-daemon
==> Tapping covesa/dlt-daemon
Cloning into '/opt/homebrew/Library/Taps/covesa/homebrew-dlt-daemon'...
remote: Repository not found.
fatal: repository 'https://github.com/COVESA/homebrew-dlt-daemon/' not found
Error: Failure while executing; `/usr/bin/env git clone https://github.com/COVESA/homebrew-dlt-daemon /opt/homebrew/Library/Taps/covesa/homebrew-dlt-daemon --origin=origin --template= --config core.fsmonitor=false` exited with 128. Here's the output:
Cloning into '/opt/homebrew/Library/Taps/covesa/homebrew-dlt-daemon'...
remote: Repository not found.
fatal: repository 'https://github.com/COVESA/homebrew-dlt-daemon/' not found

I didn't catch this because I forgot to remove the private tap I had created earlier.

I merged this change I want to make here onto 'master' of my fork then tried installing.

➜ brew tap alexmohr/dlt-daemon https://github.com/alexmohr/dlt-daemon
 brew install dlt-daemon       
==> Tapping alexmohr/dlt-daemon
Cloning into '/opt/homebrew/Library/Taps/alexmohr/homebrew-dlt-daemon'...
Tapped 1 formula (429 files, 18.3MB).

==> Fetching downloads for: dlt-daemon
✔︎ Formula dlt-daemon (master)
==> Installing dlt-daemon from alexmohr/dlt-daemon
==> cmake -S . -B build -DCMAKE_C_COMPILER=/opt/homebrew/opt/gcc/bin/gcc-16 -DCMAKE_CXX_COMPILER=/opt/homebrew/opt/gcc/bin/g++-16 -DCMAKE_INSTALL_RPATH=@loader_path/../lib -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON -DBUILD_SHARED_L
anomalyco/tap==> cmake --build build --config Release
==> cmake --install build
🍺  /opt/homebrew/Cellar/dlt-daemon/master: 36 files, 1.5MB, built in 22 seconds
==> Running `brew cleanup dlt-daemon`...
Disable this behaviour by setting `HOMEBREW_NO_INSTALL_CLEANUP=1`.
Hide these hints with `HOMEBREW_NO_ENV_HINTS=1` (see `man brew`).

[14:49:39] # MOHALEX @ rob in dlt-daemon on  master took 27.4s 
➜ dlt-daemon  
[845068.632157]~DLT~ 3551~NOTICE   ~Starting DLT Daemon; DLT Package Version: 3.0.1 STABLE, Package Revision: v3.0.0_18_gc840f29, build on Jun 16 2026 17:42:23
-SYSTEMD -SYSTEMD_WATCHDOG -TEST -SHM

[845068.632195]~DLT~ 3551~INFO     ~DLT protocol version: 1 (DLTv1)

These are the same instructions as in the readme, but covesa replaced with alexmohr.

@minminlittleshrimp minminlittleshrimp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants